Repository navigation
fix: don't add default password to users with other auth methods - #2156
Merged
alex-zaitsev merged 1 commit intoNov 16, 2026
Merged
Conversation
The normalizer gave every password-less user the template default password, except when ssl_certificates/common_name was set. A user with any other non-password method (ssl_certificates/subject_alt_name, ldap, kerberos, http_authentication, ssh_keys, no_password) ended up with two authentication methods, which ClickHouse rejects, so the pod failed to start. Skip the default password when the user already has one of those methods. LLM-assisted PR. Fixes Altinity#2155 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Craig Ringer <craig.ringer@enterprisedb.com>
Merged
alex-zaitsev
added a commit
that referenced
this pull request
Nov 16, 2026
…password Follow-up to #2156
Author
|
Thanks for the quick review. Appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't add the template default password to a user that already has a non-password authentication method. Doing so makes ClickHouse reject the user, and the pod fails to start. This operator behaviour prevents users with other authentication methods from being successfully configured as operator-managed users.
Fix by skipping injection of a default password if any of the following auth methods are already present in the user definition:
no_passwordssl_certificatesssh_keysldapkerberoshttp_authenticationThe list is in an array in the operator source code because there's no well-defined sub-key of the user definition that the operator can match for user authentication modes. So this list will need to be updated if the ClickHouse server adds new user authentication modes.
Fixes #2155
Details of the problem and a full test case & repro are in #2155 . The commit message for this PR also carries more information.