Repository navigation
Move k8s client QPS and burst into the operator config - #2137
Open
shubhamkapoor01 wants to merge 2 commits into
Open
shubhamkapoor01 wants to merge 2 commits into
shubhamkapoor01 wants to merge 2 commits into
Conversation
reconcile.runtime.k8sClientQPS and k8sClientBurst are read from the config file before the client is built. The OPERATOR_K8S_CLIENT_QPS_LIMIT and OPERATOR_K8S_CLIENT_BURST_LIMIT env vars still win when set, and 0 keeps the client-go defaults. The operator now warns at startup when reconcileShardsThreadsNumber is above the client QPS, since one CHI can then have more shards in flight than the client allows requests per second. Fixes Altinity#2045 Signed-off-by: Shubham Kapoor <66124414+shubhamkapoor01@users.noreply.github.com>
# Conflicts: # CHANGELOG.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2045
QPS and burst can now be set as
reconcile.runtime.k8sClientQPSandk8sClientBurstin the operator config file. They're read before the client is built.The env vars still win when set, so nothing changes for current setups. 0 keeps the client-go defaults (5/10 per API group).
The keys are not in the ClickHouseOperatorConfiguration CRD on purpose: a CR is read after the client exists, so a value set there could never apply.
At startup the operator now warns when
reconcileShardsThreadsNumberis above the client's QPS, env vars included.Keeper and backup reconcile through their own controller-runtime client (20/30 by default), which sees neither this setting nor the env vars. I left them alone; happy to add them here if you want the same setting there.
The config cases fail on 0.28.0. Configs, bundles and helm values were regenerated with
dev/build_manifests.shanddev/generate_helm_chart.sh.next-releasebranch, not intomasterbranch.