Repository navigation
fix(chk): prevent tight reconcile loop on status updates - #2111
Open
Tyagiquamar wants to merge 1 commit into
Open
Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A ClickHouse Keeper status-only update no longer requeues the installation and tight-loops the reconciler.
Root cause
The keeper predicate treated every update as work, including a status write that left generation, finalizers, and
deletionTimestampunchanged. The reconciler then failed to treat an unchanged generation as done, so the status write queued another reconcile.Solution
The predicate drops that pure status update. Reconcile returns immediately when the generation is unchanged, after the finalizer-install case and before
HasReconcileWork.Test plan
Test_keeperPredicateUpdatecovers a pure status update (dropped), a generation change (queued), and a finalizer change (queued).Fixes #2107