8000 Tests cleanup logic hardening by alex-zaitsev · Pull Request #2104 · Altinity/clickhouse-operator · GitHub
[go: up one dir, main page]
Skip to content

Tests cleanup logic hardening - #2104

Draft
alex-zaitsev wants to merge 3 commits into
0.28.0from
tests-cleanup-logic-hardening
Draft

Tests cleanup logic hardening#2104
alex-zaitsev wants to merge 3 commits into
0.28.0from
tests-cleanup-logic-hardening

Conversation

@alex-zaitsev
@alex-zaitsev alex-zaitsev commented Oct 12, 2026
Copy link
Copy Markdown
Member

Summary

  • Delete every CHI and CHK once with kubectl delete --wait=false, then strip only the operator finalizers so a stopped operator cannot hold the namespace.
  • Wait for those CRs together and continue namespace deletion even if one is still present.
  • Delete the namespace with --wait=false --now, and treat only NotFound as the namespace being gone.

Test plan

  • Run the e2e suite and confirm namespace teardown finishes when a CHI finalizer would previously stick.
  • Confirm a normal test still removes its CHI, CHK, and namespace.
  • Confirm test_010009 operator upgrade still completes its cleanup.

Made with Cursor

alex-zaitsev and others added 3 commits October 12, 2026 09:46
@alex-zaitsev @cursoragent
Keep test namespace teardown from hanging on operator finalizers.
3cc6d0b 
Delete every CHI and CHK once, strip only the operator finalizers, and issue namespace deletion without blocking inside kubectl.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Slach
Merge branch '0.28.0' into tests-cleanup-logic-hardening
c01c3b6
@Slach
Merge branch '0.28.0' into tests-cleanup-logic-hardening
6a3f239

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alex-zaitsev @Slach
0