Repository navigation
pkg/xml: escape reserved characters in element text - #2034
Merged
sunsingerus merged 1 commit intoJul 20, 2026
Merged
Conversation
writeValue injected element text verbatim, so passwords or values containing &, < or > produced invalid users.xml and ClickHouse failed to start. Escape those characters so the rendered document stays well-formed. Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writeValue injected element text verbatim, so passwords or values containing &, < or > produced invalid users.xml and ClickHouse failed to start. Escape those characters so the rendered document stays well-formed.
Used AI to help identify and draft this fix — reviewed and tested before submitting.