8000 add helm hooks to properly upgrade CRDs in Helm chart without manual updates and without separate Helm chart by Slach · Pull Request #1862 · Altinity/clickhouse-operator · GitHub
[go: up one dir, main page]

Skip to content
< 8000 div id="diff-comparison-viewer-container" class="Container__qkpM1i tmp-mt-4 container-xl tmp-px-3 tmp-px-md-4 tmp-px-lg-5 ContainerSidePanel__47M93r" data-side-panel-open="false" data-hovercard-subject-tag="pull_request:3028689635">

add helm hooks to properly upgrade CRDs in Helm chart without manual updates and without separate Helm chart - #1862

Merged
sunsingerus merged 20 commits into
0.25.6from
improve_helm
Dec 10, 2025
Merged

sunsingerus merged 20 commits into
0.25.6from
improve_helm

Conversation

@Slach
@Slach Slach commented Nov 20, 2025
Copy link
Copy Markdown
Collaborator

Important items to consider before making a Pull Request

Please check items PR complies to:

  • All commits in the PR are squashed. More info
  • The PR is made into dedicated next-release branch, not into master branch1. More info
  • The PR is signed. More info

--

1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into master branch, but it has to be confirmed by project's maintainer.

Slach and others added 9 commits August 12, 2025 07:55
Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <aider@aider.chat>
Co-authored-by: aider (openrouter/qwen/qwen3-coder) <aider@aider.chat>
Co-authored-by: aider (openrouter/qwen/qwen3-coder) <aider@aider.chat>
Co-authored-by: aider (openrouter/qwen/qwen3-coder) <aider@aider.chat>
…helm_chart.sh, remove duplicated strategy from Deployment-clickhouse-operator.yaml
Signed-off-by: Slach <bloodjazman@gmail.com>
… improve_helm

Signed-off-by: Slach <bloodjazman@gmail.com>

# Conflicts:
#	deploy/helm/clickhouse-operator/values.schema.json
# Cleanup
cd /
rm -rf "$TEMP_DIR"
name: release_chart
@Slach Slach Nov 20, 2025 •
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird, this is looks like line endings changed, but i didn't

file identical

}
}
}
{
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same, i have LF line endings here, maybe on github it CRLF

Signed-off-by: Slach <bloodjazman@gmail.com>
@Slach
Slach commented Nov 20, 2025 •
Copy link
Copy Markdown
Collaborator Author

root reason why check_helm fails
Warning Failed 28s (x3 over 81s) kubelet Failed to pull image "altinity/clickhouse-operator:0.25.6": Error response from daemon: manifest for alt inity/clickhouse-operator:0.25.6 not found: manifest unknown: manifest unknown

@joshleecreates
Copy link
Copy Markdown
Contributor

root reason why check_helm fails Warning Failed 28s (x3 over 81s) kubelet Failed to pull image "altinity/clickhouse-operator:0.25.6": Error response from daemon: manifest for alt inity/clickhouse-operator:0.25.6 not found: manifest unknown: manifest unknown

I believe that under the new repo the chart name is altinity-clickhouse-operator

@Slach
Slach commented Nov 21, 2025
Copy link
Copy Markdown
Collaborator Author

@joshleecreates images just not published yet, this is root reason, i install helm from local directory

Signed-off-by: Slach <bloodjazman@gmail.com>
Signed-off-by: Slach <bloodjazman@gmail.com>

# Conflicts:
#	.gitignore
Signed-off-by: Slach <bloodjazman@gmail.com>
Signed-off-by: Slach <bloodjazman@gmail.com>
Signed-off-by: Slach <bloodjazman@gmail.com>
@Slach
Slach commented Nov 21, 2025
Copy link
Copy Markdown
Collaborator Author

ok. check helm passed, ready to merge

Signed-off-by: Slach <bloodjazman@gmail.com>
@sunsingerus
sunsingerus merged commit fd9242e into 0.25.6 Dec 10, 2025
2 of 3 checks passed
@sunsingerus
sunsingerus deleted the improve_helm branch June 4, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0