8000 chore: use ConfigMap instead of Secret for grafana dashboards by cwrau · Pull Request #1457 · Altinity/clickhouse-operator · GitHub
[go: up one dir, main page]

Skip to content

chore: use ConfigMap instead of Secret for grafana dashboards - #1457

Merged
Slach merged 1 commit into
Altinity:0.24.0from
cwrau:chore/use-configmap-instead-of-secret-for-dashboards
Jul 16, 2024
Merged

Slach merged 1 commit into
Altinity:0.24.0from
cwrau:chore/use-configmap-instead-of-secret-for-dashboards

Conversation

@cwrau
@cwrau cwrau commented Jul 15, 2024 •
Copy link
Copy Markdown
Contributor

secrets should only be used for sensitive data, which dashboards are not

secrets should only be used for sensitive data, which dashboards are not
@cwrau cwrau changed the title chore: use ConfigMap instead of Secret for grafana dashboards secrets should only be used for sensitive data, which dashboards are not chore: use ConfigMap instead of Secret for grafana dashboards Jul 15, 2024
@Slach
Slach changed the base branch from master to 0.24.0 July 16, 2024 13:38
@Slach
Slach commented Jul 16, 2024
Copy link
Copy Markdown
Collaborator

yep, according to https://github.com/grafana/helm-charts/blob/grafana-8.3.4/charts/grafana/values.yaml#L778
it should be configMap instead of secrets

@Slach
Slach merged commit 6c9691b into Altinity:0.24.0 Jul 16, 2024
Slach added a commit that referenced this pull request Jul 16, 2024
Signed-off-by: Slach <bloodjazman@gmail.com>
@marvinWolff marvinWolff mentioned this pull request Oct 23, 2024
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0