Repository navigation
Generate operator helm chart - #1049
Merged
Merged
Conversation
slamdev
marked this pull request as ready for review
November 13, 2022 14:59
Slach
self-requested a review
November 16, 2022 10:32
Slach
approved these changes
Dec 7, 2022
Collaborator
There was a problem hiding this comment.
LGTM
but small cosmetic comments
and main concern
if we generate grafana dashboards
could we add optional dependency to Chart.yaml for this use case
| @@ -0,0 +1,83 @@ | |||
| {{/* vim: set filetype=mustache: */}} | |||
Collaborator
There was a problem hiding this comment.
could we change it to go-template?
Slach
added a commit
that referenced
this pull request
Dec 7, 2022
…h call to go_build_all.sh Signed-off-by: Slach <bloodjazman@gmail.com>
Slach
added a commit
that referenced
this pull request
Dec 12, 2022
Signed-off-by: Slach <bloodjazman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AIM of this PR is to migrate altinity-clickhouse-operator chart to the official repo.
PR contains a lot of auto-generated files, so it makes sense to review commits individually.
Things yet to cover:
./dev/generate_helm_chart.shafter the script that generatesdeploy/operator/clickhouse-operator-install-bundle.yamlSample of the release pipeline: https://github.com/slamdev/clickhouse-operator/actions/runs/3455712508/jobs/5767926291
Chart archive is attached to a release: https://github.com/slamdev/clickhouse-operator/releases/tag/release-0.20.0
Autogenerated index.yaml: https://github.com/slamdev/clickhouse-operator/blob/gh-pages/index.yaml
Chart is available via github pages:
Prerequisite: create
gh-pagesbranch and make sure it's empty.Actions after the first chart release:
closes #1024 #941 #837 #620
partially solves #558