Repository navigation
Conversation
Issue #941 asked to replace AsyncStatus.commands with a map + slice and keep only the last N actions. That was already done for #1481 (PR #1482): rows are addressed by monotonic id via byId, finished rows are trimmed to general.status_history_size. The only remaining change is the default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
Coverage Report for CI Build 37731268662Coverage at 69.61% (no base build to compare)Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #941
The structural part of #941 (map + slice in
AsyncStatus, keep only the last N action rows) was already implemented for #1481 in #1482 and released in v2.8.1:AsyncStatus.commandsis an ordered slice, rows are resolved by a monotonic id throughbyId map[int]*ActionRowtrimLockeddrops the oldest finished rows beyondgeneral.status_history_size(envSTATUS_HISTORY_SIZE); in-progress rows and canceled rows whose goroutine has not reachedStopare never droppedThis PR only changes the default from
1000to1024(status.DefaultMaxFinishedRows, config default, ReadMe, testflows default-config snapshot, unit test, ChangeLog).🤖 Generated with Claude Code