8000 Stable 26.3 - enable powerpc builds by strtgbb · Pull Request #2937 · Altinity/ClickHouse · GitHub
[go: up one dir, main page]

Skip to content

Stable 26.3 - enable powerpc builds - #2937

Open
strtgbb wants to merge 12 commits into
stable-26.3from
ci/stable-26.3/enable-ppc
Open

strtgbb wants to merge 12 commits into
stable-26.3from
ci/stable-26.3/enable-ppc

Conversation

@strtgbb
@strtgbb strtgbb commented Nov 20, 2026 •
Copy link
Copy Markdown
Collaborator

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • Aarch64 tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • CAS (content-addressed storage; Antalya only)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • OAuth (5m)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • S3 Export (2h)
  • Swarms (30m)
  • Tiered Storage (2h)

@strtgbb
strtgbb requested a review from vzakaznikov November 20, 2026 15:51
@strtgbb strtgbb added cicd Improvements and fixes to the CICD process stable-26.3 labels Nov 20, 2026
@github-actions
github-actions Bot commented Nov 20, 2026 •
Copy link
Copy Markdown

Workflow [PR], commit [4fbc1cb]

strtgbb and others added 6 commits November 20, 2026 13:56
ppc64le frames exceed -Wframe-larger-than=65536 under -Werror, and defining __SSE2__ compiles x86 intrinsic paths that the PowerPC compatibility headers do not implement.

Co-authored-by: Cursor <cursoragent@cursor.com>
stxvd2x stores the doublewords swapped, and the existing xxswapd leaves callee-saved registers swapped when the call returns. Apply that fix to a build-directory copy so the llvm-project pin stays unchanged.

Co-authored-by: Cursor <cursoragent@cursor.com>
The job cross-compiles on an AMD builder, so confirm the libunwind copy and the ppc64le compiler flags before ninja starts.

Co-authored-by: Cursor <cursoragent@cursor.com>
The AMD func tester cannot exec the cross-built ELF, so the job registers qemu-user and runs clickhouse local inside a ppc64le Debian container.

Co-authored-by: Cursor <cursoragent@cursor.com>
The unconditional compile option applied 128 KiB to every architecture, including Debug and sanitizer builds that were exempt from the 64 KiB check.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jsc0218
jsc0218 commented Nov 20, 2026
Copy link
Copy Markdown

ppc64le patch check fails on a false negative

Build (ppc64le) on c330fa3f fails in the ppc64le patch check step, before ninja starts:

CMAKE_CXX_FLAGS missing ppc64le AltiVec flags:

check_ppc64le_patches reads CMAKE_CXX_FLAGS from CMakeCache.txt, but that entry is empty (CMAKE_CXX_FLAGS:STRING=). ClickHouse's cmake builds the flags as a normal variable, so they never reach the cache. The flags are applied, though. The ppc configure log shows -maltivec -mcpu=power8 and -Wframe-larger-than=131072, and -D__SSE2__ appears nowhere.

The libunwind half of the check passed, since the failure comes 8000 after it. The ppc build and Smoke test (ppc64le) therefore haven't run yet.

Suggested fix: drop the CMAKE_CXX_FLAGS check, or read the flags from build.ninja (grep the FLAGS = lines for -maltivec and for the absence of -D__SSE2__). The configure step already fails hard if ppc64le-vsx-register-save.patch can't apply, so the guard adds little.

Smoke test images:

  • ci/jobs/smoke_test_ppc64le.py uses multiarch/qemu-user-static with no tag, and debian:bookworm with no digest. Please pin both by tag and @sha256.
  • docker run --privileged ... --reset -p yes re-registers binfmt on the shared runner. If it's convenient, docker/setup-qemu-action or tonistiigi/binfmt would be a more contained way to do it.

Context: the unw_getcontext fix is only in ClickHouse master and the 26.11 branch (ClickHouse PR ClickHouse#129808). The 26.3 and 26.8 pins don't have it, so the cmake patch is valid on stable-26.3 for now. A later rebase onto a pin that includes the fix will make patch fail and cmake abort, so the patch should be removed in that change.

strtgbb and others added 5 commits November 20, 2026 18:51
CMAKE_CXX_FLAGS in CMakeCache.txt stays empty, so the patch check failed before ninja started even though the flags were applied.

https: //github.com//pull/2937#issuecomment-7052315983
Co-authored-by: Cursor <cursoragent@cursor.com>
The unpinned images can move, and resetting every binfmt handler rewrites the shared runner.

https: //github.com//pull/2937#issuecomment-7052315983
Co-authored-by: Cursor <cursoragent@cursor.com>
… round-trip.

Start `clickhouse-server` with the default server config so `SystemLogs` initializes, run a `MergeTree` create/insert/select round-trip and a `throwIf` unwind check, and verify clean `SIGTERM` shutdown.

Co-authored-by: Cursor <cursoragent@cursor.com>
The copied file is compiled from the build directory, so the quoted include no longer finds assembly.h next to the original source.

https: //github.com/Altinity/ClickHouse/actions/runs/44844313916/job/136740770674
Co-authored-by: Cursor <cursoragent@cursor.com>
An empty TZ is a timezone name, so the server exits while resolving /usr/share/zoneinfo. Unset TZ falls back to UTC.

https: //github.com/Altinity/ClickHouse/actions/runs/44916050590/job/136930884522
Co-authored-by: Cursor <cursoragent@cursor.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

26.3.64.10001 cicd Improvements and fixes to the CICD process stable-26.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0