Repository navigation
Fix wrong condition for direct io on export part/ partition - #2824
arthurpassos wants to merge 1 commit into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a79f343a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| bool apply_deleted_mask = true; | ||
| bool read_with_direct_io = local_context->getSettingsRef()[Setting::min_bytes_to_use_direct_io] > manifest.data_part->getBytesOnDisk(); | ||
| const UInt64 min_bytes_to_use_direct_io = local_context->getSettingsRef()[Setting::min_bytes_to_use_direct_io]; | ||
| bool read_with_direct_io = min_bytes_to_use_direct_io != 0 && manifest.data_part->getBytesOnDisk() >= min_bytes_to_use_direct_io; |
There was a problem hiding this comment.
Apply the threshold to the whole exported partition
For EXPORT PARTITION, both partition schedulers invoke exportPartToTable separately for each part, so this comparison evaluates each part in isolation rather than the total data volume of the export. For example, a partition containing two 60 MiB parts with min_bytes_to_use_direct_io = 100 MiB reads 120 MiB overall but disables direct I/O for both parts, contrary to the setting's total-volume semantics. Persist the aggregate partition size or a precomputed direct-I/O decision in the partition descriptor and use that decision for every part; retain this per-part calculation only for EXPORT PART.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
hm... not sure if this is a good idea, it might be
|
Possible issue found by AI, cleaned up for conciseness. An export can still open column files with
Related lines of code: |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix wrong condition for direct io on export part/ partition
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: