8000 Antalya 26.6: port the CAS fixes merged into antalya-26.8 (PR 2730, 2773) by filimonov · Pull Request #2806 · Altinity/ClickHouse · GitHub
[go: up one dir, main page]
Skip to content < 8000 react-partial partial-name="keyboard-shortcuts-dialog" data-ssr="false" data-attempted-ssr="false" data-react-profiling="false" >

Antalya 26.6: port the CAS fixes merged into antalya-26.8 (PR 2730, 2773) - #2806

Open
filimonov wants to merge 2 commits into
antalya-26.6from
port/antalya-26.6/cas-from-26.8
Open

Antalya 26.6: port the CAS fixes merged into antalya-26.8 (PR 2730, 2773)#2806
filimonov wants to merge 2 commits into
antalya-26.6from
port/antalya-26.6/cas-from-26.8

Conversation

@filimonov
@filimonov filimonov commented Nov 6, 2026
Copy link
Copy Markdown
Member

Port to antalya-26.6 of the two CAS PRs merged into antalya-26.8 since the combined port #2540. One commit per source PR, cherry-picked from the PR merge commit; conflict notes are in the commit messages.

  • Fix early manifest deletion in CAS GC #2730 Fix early manifest deletion in CAS GC [Critical Bug Fix]. The orphan sweep nominated a rowless manifest without a floor check (CAS-435). Conflicts against the 26.6 decommission code: CasOrphanManifestSweep.cpp keeps the min_active_build_sequence == max sentinel test, which is what MountLease::isCleanRelease means on 26.6, and sweepNamespace keeps the 26.6 admission through mountRequests; CasDecommission.cpp comment only.
  • CAS: Reject content part writes through encrypted CAS disks #2773 Reject content part writes through encrypted CAS disks [Bug Fix]. Clean pick: the explicit NOT_IMPLEMENTED in DiskEncryptedTransaction::writeFileImpl fires before the delegate write on 26.6 as well, and the new integration test test_cas_encrypted_disk pins the message.

Not ported: #2794 (open; written against the PublishPolicy promote of PR 2647, 26.6 has allow_repoint), and the 26.8-only owner Move / disk transaction / packed parts / backup series (2579, 2647, 2704, 2508).

Local check: release unit_tests_dbms --gtest_filter='CAS*' 2838 passed, 0 failed (2823 on the base plus the 15 tests of PR 2730). The integration test of PR 2773 runs in CI.

Related: #2805

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

CAS (content-addressed storage): the orphan manifest sweep no longer deletes a rowless manifest whose build is still under the mount floor; writes of content part files through an encrypted CAS disk are rejected with NOT_IMPLEMENTED instead of failing later.

Documentation entry for user-facing changes

  • No documentation change: ported PRs carry none.

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • Aarch64 tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • CAS (content-addressed storage; Antalya only)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • OAuth (5m)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • S3 Export (2h)
  • Swarms (30m)
  • Tiered Storage (2h)

filimonov and others added 2 commits November 6, 2026 03:04
@filimonov @claude
Fix early manifest deletion in CAS GC
e7b4530 
Port of #2730 (antalya-26.8) to antalya-26.6.

Conflicts: `Gc/CasOrphanManifestSweep.cpp` (`buildPrefixEligibleUnderFloor` keeps the
`min_active_build_sequence == max` sentinel test, which is what `MountLease::isCleanRelease` means
here; `sweepNamespace` keeps the antalya-26.6 `mountRequests` admission with the renamed
eligibility helper), `Tools/CasDecommission.cpp` (comment only).

(cherry picked from commit 856ca70)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Mikhail Filimonov <mfilimonov@altinity.com>
@filimonov @claude
CAS: Reject content part writes through encrypted CAS disks
300a8c1 
Port of #2773 (antalya-26.8) to antalya-26.6.

(cherry picked from commit 86c6de4)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Mikhail Filimonov <mfilimonov@altinity.com>
@github-actions
github-actions Bot commented Nov 6, 2026
Copy link
Copy Markdown

Workflow [PR], commit [300a8c1]

@blau-ai blau-ai mentioned this pull request Nov 6, 2026
Merged
9 of 30 tasks

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k-morozov k-morozov k-morozov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@filimonov @k-morozov
0