Repository navigation
Stable 26.3 Backport of #102156 - Fix Nullable(X)->Y cross-type ALTER MODIFY COLUMN - #2711
Merged
Merged
Conversation
…pe-modify-upstream Fix Nullable(X)->Y cross-type ALTER MODIFY COLUMN
9 of 30 tasks
Member
Author
Collaborator
CI triage for
|
| Check | Failing tests | Verdict | Evidence |
|---|---|---|---|
| Integration (amd_asan, old analyzer, 5/8) and (amd_binary, 4/5) | all 16 tests in test_database_glue/test.py |
Already failing on base | Same 16 failures on #2706 and #2696 |
| Integration (amd_asan, old analyzer, 3/8) and (amd_binary, 2/5) | test_storage_s3/test_sts.py::test_sts_smoke, test_sts_smoke_s3cluster, test_sts_credentials_cache |
Already failing on base | Same 3 failures on #2706 |
| Stateless (amd_debug, sequential) and (distributed plan, s3 storage, sequential) | 03271_s3_table_function_asterisk_glob, 02789_filesystem_cache_alignment |
Already failing on base (network/timeout) | Timeout exceeded while receiving data from server. Waited for 300 seconds on a public S3 bucket. Same pair fails on #2706 and #2683 |
| Stateless (amd_debug, parallel) | 03634_autopr_input_bytes_estimation |
Already failing on base | Also fails on #2696 |
| Stateless (distributed plan, s3 storage, parallel) | 04033_tpc_ds_q14 |
Already failing on base | Also fails on #2706 and #2696 |
| Stateless (amd_ubsan, parallel) | Some queries hung |
Already failing on base | Same result on #2706 |
| Stateless (amd_debug, sequential) | 00077_log_tinylog_stripelog, Scraping system tables |
Slow runner, not this PR | See below |
| DCO | no sign-off on the upstream merge commit | Process check | Also fails on #2696 and #2706; it fails on every backport PR |
The two failures found only on this PR (amd_debug, sequential)
00077_log_tinylog_stripelog:That is about 13k rows/s readingCode: 160. DB::Exception: Estimated query execution time (681.51544 seconds) is too long. Maximum: 600. Estimated rows to process: 8873898 (3915776 read in 300.73163 seconds) ... (TOO_SLOW) (in query: INSERT INTO test.hits_log SELECT CounterID, AdvEngineID, RegionID, SearchPhrase, UserID FROM test.hits;)test.hits, which means the machine was starved. The job ran for about 2h53m (10363 s); the same job on Stable 26.3 Backport of #127318 - Distrust the compromised eMudhra certificates #2696 took 58 min. Other tests in the same job also hit 300 s timeouts.Scraping system tables:System table trace_log has too many rows 10090547 > 10000000. This is a side effect of the job running that long.- Why this PR can't be the cause: the diff only changes
convertRequiredExpressions(), in the branch where a part storesNullable(X)but the table now expects a different non-Nullable typeYafterALTER MODIFY COLUMN.test.hitshas never been altered that way, so reads from it never reach the changed code.
Suggested next steps
- Nothing to fix in the PR. If you want a cleaner signal, re-run
Stateless tests (amd_debug, sequential)on its own. - The Glue, STS and S3 timeout failures are base-branch problems on
stable-26.3and should be tracked separately from this backport.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed
ALTER MODIFY COLUMNfailing when converting aNullablecolumn to a different type with aDEFAULT(e.g.Nullable(UInt8)→String,LowCardinality(String), orArray(UInt8)). (ClickHouse#102156 by @il9ue)Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: