8000 Antalya 26.6, backport of 103936: Puffin file reader by ianton-ru · Pull Request #2179 · Altinity/ClickHouse · GitHub
[go: up one dir, main page]

Skip to content

Antalya 26.6, backport of 103936: Puffin file reader - #2179

Merged
zvonand merged 4 commits into
antalya-26.6from
backport/antalya-26.6/103936
Aug 7, 2026
Merged

zvonand merged 4 commits into
antalya-26.6from
backport/antalya-26.6/103936

Conversation

@ianton-ru
Copy link
Copy Markdown

Backport of ClickHouse#103936 by @scanhex12

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Added support for Puffin file format (https://iceberg.apache.org/puffin-spec/). Now this format can be used in table functions like file, url, s3 and so on.. (ClickHouse#103936 by @scanhex12)

@ianton-ru
Copy link
Copy Markdown
Author

No conflicts during backport.

@github-actions
github-actions Bot commented Aug 6, 2026 •
Copy link
Copy Markdown

Workflow [PR], commit [0c7c97f]

@mkmkme mkmkme left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mkmkme
mkmkme commented Aug 7, 2026
Copy link
Copy Markdown
Collaborator

@blau-ai

@blau-ai
blau-ai commented Aug 7, 2026
Copy link
Copy Markdown
Collaborator

CI triage — 8 red checks, 0 caused by this PR

Verdict: 1 DCO/process issue · 4 pre-existing regression-suite feature gaps · 3 infra/network-flaky. None touch the Puffin/Iceberg code this PR adds. Every build (14/14: debug, asan/ubsan, tsan, msan, release — amd+arm), Fast test, all the PR's own *_puffin_* stateless tests, AST fuzzer and Grype are green. src/Formats/registerFormats.cpp is purely additive (it only registers the new Puffin input format + schema reader), so it cannot affect unrelated formats.

Evidence is from the completed job logs of run 31160829763 at 0c7c97f.


1. DCO — fail (process, PR-related but not code)

There is one commit incorrectly signed off … 58814ab Merge pull request #103936 from scanhex12/puffin_reader — Sign-off not found

The cherry-picked upstream merge commit has no Signed-off-by trailer. Not a code problem.
Fix: a maintainer rebases the branch adding Signed-off-by to that commit (history rewrite / force-push — outside my permissions), or the DCO status is manually overridden. Nothing to change in the diff.

2. Stateless tests (amd_debug, parallel) — fail — Failed: 3, Broken: 3 — not PR-related

The failing tests are all network / external-dataset dependent and none are Puffin tests (every 04077/04257/04260/04548/04549/04612/04613/04655_puffin_* passed):

01854_HTTP_dict_decompression                     [ FAIL ]
00154_avro                                         [ FAIL ]
03595_extract_url_parameters                       [ FAIL ]
04070_url_base_setting                             [ BROKEN ]
03441_deltalake_clickhouse_virtual_columns         [ BROKEN ]
03441_deltalake_clickhouse_public_datasets         [ BROKEN ]

These exercise HTTP dictionaries, Avro-over-URL, URL functions and DeltaLake public datasets — i.e. outbound network, which is restricted on this runner (same root cause as #5 below). Pre-existing/flaky infra.
Next step: safe to re-run; if they persist they are environmental, not this PR.

3. Unit tests (tsan) — fail — not PR-related

The build's own summary line is misleading (received signal SIGINT); the backtrace shows the CI watchdog interrupting a hung test:

#7 DB::Common_ReverseDNS_Test::TestBody () at src/Common/tests/gtest_dns_reverse_resolve.cpp:55
...
Fail [Common.ReverseDNS]

Common.ReverseDNS blocks on a reverse-DNS lookup (thread join) that never returns on a network-restricted runner. This PR's unit test (gtest_iceberg_schema_processor) did not fail. Infra/flaky.
Next step: safe to re-run.

4 & 5. Regression release s3_export_part / s3_export_partition — fail — not PR-related

Both fail at feature support validation, before any real testing:

[ Fail ] '/s3/minio/export tests/export part/feature support validation'
    ᐅ Export merge tree part is not supported by this build; the feature is not present in this version.

The clickhouse-regression suite expects the S3 "export part/partition" feature, which is not present in the antalya-26.6 build. This is a suite-vs-branch version gap that fails on every PR targeting this branch, unrelated to Puffin.
Next step: expected red on antalya-26.6; ignore for this PR (a maintainer can confirm it's red on the base branch too).

6. Regression release swarms — fail — not PR-related

Same shape as above:

[ Fail ] '/swarms/feature support validation'
    ᐅ Swarm object_storage_cluster is not supported by this build; the feature is not present in this version.

(24 retries all OK; only the feature-gate scenario fails.) Feature not in the 26.6 build. Unrelated.

7. Regression release oauth / RegressionTestsRelease OAuth — fail — not PR-related

OAuth suite drives an external Keycloak + LocalStack identity provider (--identity-provider keycloak, LOCALSTACK_AUTH_TOKEN). Report shows 1 scenario (1 failed) with 1 retry (1 ok) — it passed on retry, a classic environmental flake. Nothing to do with a file-format reader.
Next step: safe to re-run.


Bottom line

This is a healthy PR. The backported Puffin reader builds cleanly across all sanitizers and both architectures, and all of its dedicated stateless tests pass. The only action item that concerns this PR directly is DCO — the upstream merge commit 58814ab needs a Signed-off-by (rebase + force-push by a maintainer, or a manual DCO override). The remaining 7 red checks are pre-existing regression-suite feature gaps against antalya-26.6 or network-restricted-runner flakes and can be safely re-run / ignored.

🤖 Automated CI triage by @blau-ai. I can't build or run ClickHouse in this container; classifications are from CI logs. Correctness of the code is validated by the green builds + the PR's own passing Puffin tests.

@zvonand
zvonand merged commit 6569382 into antalya-26.6 Aug 7, 2026
270 of 294 checks passed
@mkmkme mkmkme added the verified Approved for release label Aug 7, 2026
ianton-ru added a commit that referenced this pull request Aug 7, 2026
…arser.

Related: #2179
Related: #2183
Co-authored-by: Cursor <cursoragent@cursor.com>
ianton-ru added a commit to ianton-ru/ClickHouse that referenced this pull request Aug 7, 2026
…arser.

Related: Altinity#2179
Related: Altinity#2183
Co-authored-by: Cursor <cursoragent@cursor.com>
@subkanthi subkanthi mentioned this pull request Sep 16, 2026
10 of 17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

0