-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstraction that allows us to develop different agents, frontend, backend, and evaluation in parallel #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think |
This is awesome, super helpful for experimentation 🚀 |
huybery
approved these changes
Mar 20, 2024
neubig
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too, thanks for this!
xcodebuild
pushed a commit
to xcodebuild/OpenDevin
that referenced
this pull request
Mar 31, 2024
…kend, and evaluation in parallel (All-Hands-AI#68) * move agent to langchains_agent * remove old .env * remove the old agent folder * add preliminary version of Agent abstraction * add preliminary version of the main.py * merge controlloop and main into a Agent class * add init * fix json import * fix missing arg * get langchains_agent working after abstraction * rename `research` to `agenthub` * rename: rename research to agenthub --------- Co-authored-by: huybery <huybery@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discuss here, i suggests that we can:
Agent
abstraction (with every necessary method for Devin) where everyone agrees onAgent
underagenthub/
so we can leverage our potential large pool of contributors to experiment and explore different ideasAgent
abstraction, and when MVP implementation is completed, the same front- and back-end system can easily switch between multiple differentAgent
implementationsI took the first (not perfect) step towards this goal - I draft the first version of
Agent
abstraction, merge @rbren'sagent
underresearch/langchains_agent
(pls let me know if you prefer a different name! :P ), subclass the generalAgent
abstraction, and make the originalagents/main.py
more general (you can just change a command line argument to switch between completely different agent implementation!)And i made sure the code works now for @rbren's agent:
produces outputs:
TODOs after this PR is merged:
research/langchains_agent/regression
supposed to test whether an agent can complete the tasks? If so, I'd suggest maybe we can move it into a sub-folder ofevaluation
and add a TODO that writes actual test cases these to test anyAgent
implementation against these regression tests - what do you think?langchains_agent
once Minimal Docker Sandbox with GPT-3.5 Execution Example #48 is merged (no big difference) and updatebuild-and-run.sh
correspondinglyrequirements.txt
(or maybe not since these will be installed inside the docker container?)