This repository was archived by the owner on Oct 5, 2023. It is now read-only.
Repository navigation
standard param naming - #204
Merged
Merged
Conversation
Arjen Huitema (arjenhuitema)
requested review from
Alboroni and
Paul Grimley (paulgrimley)
July 14, 2023 23:03
Paul Grimley (paulgrimley)
approved these changes
Jul 17, 2023
Contributor
There was a problem hiding this comment.
LGTM, approved and will merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Naming of the parameters and policyDefinitionReferenceId was not updated previously.
Now both the management and landingzone parameter files as well as both policy sets have the updated naming for the new rsv alerts.