8000 Recovery services vault by arjenhuitema · Pull Request #177 · Azure/alz-monitor · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Oct 5, 2023. It is now read-only.

Recovery services vault - #177

Merged
Jan Faurskov (jfaurskov) merged 17 commits into
Azure:mainfrom
arjenhuitema:recovery-services-vault
Jun 19, 2023
Merged

Jan Faurskov (jfaurskov) merged 17 commits into
Azure:mainfrom
arjenhuitema:recovery-services-vault

Conversation

@arjenhuitema
Copy link
Copy Markdown
Collaborator

File changes:

  • Removed: src\resources\Microsoft.Authorization\policyDefinitions\deploy-rv_backuphealth_alert.bicep
  • Removed: src\resources\Microsoft.Authorization\policyDefinitions\deploy-rv_backuphealth_alert.json
  • Added: src\resources\Microsoft.Authorization\policyDefinitions\deploy-rv_backuphealth_monitor.bicep

Changes to infra-as-code\bicep\deploy_dine_policies.bicep:

  • Removed deployment: module rv_backuphealth_policy '../../src/resources/Microsoft.Authorization/policyDefinitions/deploy-rv_backuphealth_alert.bicep'
  • Added deployment: module rv_backuphealthmonitor_policy '../../src/resources/Microsoft.Authorization/policyDefinitions/deploy-rv_backuphealth_monitor.bicep'

Changes to src\resources\Microsoft.Authorization\policySetDefinitions\ALZ-MonitorLandingZone.json:

Removed parameters:

  • RVBackupHealthAlertSeverity
  • RVBackupHealthWindowSize
  • RVBackupHealthEvaluationFrequency
  • RVBackupHealthPolicyEffect
  • RVBackupHealthAlertState
  • RVBackupHealthThreshold

Added Parameters

  • RVBackupHealthMonitorPolicyEffect

Other:

  • Removed PolicyDefinition: "policyDefinitionId": "[concat('/providers/Microsoft.Management/managementGroups/',managementGroup().name, '/providers/Microsoft.Authorization/policyDefinitions/Deploy_RecoveryVault_BackupHealth_Alert')]"
  • Added PolicyDefinition: "policyDefinitionId": "[concat('/providers/Microsoft.Management/managementGroups/',managementGroup().name, '/providers/Microsoft.Authorization/policyDefinitions/Deploy_RecoveryVault_BackupHealthMonitor_Alert')]"

Changes to: infra-as-code\bicep\parameters-complete-landingzones.json:

Removed parameters:

  • RVBackupHealthAlertSeverity
  • RVBackupHealthWindowSize
  • RVBackupHealthEvaluationFrequency
  • RVBackupHealthPolicyEffect
  • RVBackupHealthAlertState
  • RVBackupHealthThreshold

Added parameters:

  • RVBackupHealthMonitorPolicyEffect

Changes to: docs\wiki\PolicyInitiatives.md:

  • Updated LZ table, removing old definition and including the new RSV alert definition.

Evidence

Policy deployment

image

Remediation

image

Vault configuration
image

@jfaurskov Jan Faurskov (jfaurskov) left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Arjen Huitema (@arjenhuitema), just a few comments :-)

Co-authored-by: Jan Faurskov <22591930+jfaurskov@users.noreply.github.com>
Co-authored-by: Jan Faurskov <22591930+jfaurskov@users.noreply.github.com>
@jfaurskov Jan Faurskov (jfaurskov) left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Arjen Huitema (@arjenhuitema) could you please update the link to MonitoringAndAlerting in the main Readme as well? Then I'll approve :-)

@arjenhuitema
Copy link
Copy Markdown
Collaborator Author

Great work Arjen Huitema (@arjenhuitema) could you please update the link to MonitoringAndAlerting in the main Readme as well? Then I'll approve :-)

Done! Thanks Jan.

@jfaurskov Jan Faurskov (jfaurskov) left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfaurskov
Jan Faurskov (jfaurskov) merged commit ddd8067 into Azure:main Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0