This repository was archived by the owner on Oct 5, 2023. It is now read-only.
Repository navigation
Recovery services vault - #177
Merged
Jan Faurskov (jfaurskov) merged 17 commits intoJun 19, 2023
Merged
Conversation
Arjen Huitema (arjenhuitema)
requested review from
Alboroni and
Jan Faurskov (jfaurskov)
June 12, 2023 16:12
Jan Faurskov (jfaurskov)
suggested changes
Jun 13, 2023
Collaborator
There was a problem hiding this comment.
Great work Arjen Huitema (@arjenhuitema), just a few comments :-)
Co-authored-by: Jan Faurskov <22591930+jfaurskov@users.noreply.github.com>
Co-authored-by: Jan Faurskov <22591930+jfaurskov@users.noreply.github.com>
Jan Faurskov (jfaurskov)
self-requested a review
June 14, 2023 09:48
…tema/alz-monitor into recovery-services-vault
Jan Faurskov (jfaurskov)
suggested changes
Jun 15, 2023
Collaborator
There was a problem hiding this comment.
Great work Arjen Huitema (@arjenhuitema) could you please update the link to MonitoringAndAlerting in the main Readme as well? Then I'll approve :-)
Collaborator
Author
Done! Thanks Jan. |
Jan Faurskov (jfaurskov)
self-requested a review
June 16, 2023 07:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File changes:
Changes to infra-as-code\bicep\deploy_dine_policies.bicep:
Changes to src\resources\Microsoft.Authorization\policySetDefinitions\ALZ-MonitorLandingZone.json:
Removed parameters:
Added Parameters
Other:
Changes to: infra-as-code\bicep\parameters-complete-landingzones.json:
Removed parameters:
Added parameters:
Changes to: docs\wiki\PolicyInitiatives.md:
Evidence
Policy deployment
Remediation
Vault configuration
