8000 Alleviating Parameter confusion by pkorolo · Pull Request #167 · Azure/alz-monitor · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Oct 5, 2023. It is now read-only.

Alleviating Parameter confusion - #167

Merged
Arjen Huitema (arjenhuitema) merged 9 commits into
Azure:mainfrom
pkorolo:branchFor28605
Jun 9, 2023
Merged

Arjen Huitema (arjenhuitema) merged 9 commits into
Azure:mainfrom
pkorolo:branchFor28605

Conversation

@pkorolo
Copy link
Copy Markdown
Contributor

This is for User Story 28605

@jfaurskov Jan Faurskov (jfaurskov) changed the title PR for 28605 Alleviating Parameter confusion May 31, 2023
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Panagiotis Korologos (@pkorolo), the changes to the document are great and it clarifies very well the use of the current parameters.

To further clarify, I suggest changing the parameter names. When assigning the initiatives, the parameter name is nearly identical to the cli parameter.

Deployment variable:
**managementGroupId**="The pseudo root management group id"

Assigning initiative:
az deployment mg create --template-file ./infra-as-code/bicep/assign_initiatives_identity.bicep --location $location **--management-group-id** $identityManagementGroup --parameters ./infra-as-code/bicep/parameters-complete-identity.json

Parameter file:

        "**parPolicyManagementGroupId**": {

            "value": "alz"

I think we should change the naming of our parameters that reference the "top-level/ pseudo root" into something more descriptive like psuedoRootManagementGroupId.

@pkorolo
Copy link
Copy Markdown
Contributor Author

gentlemen Arjen Huitema (@arjenhuitema) Jan Faurskov (@jfaurskov) let's sync during our weekly meeting; or I could sync with Jan tomorrow, to further clarify what is required (because to my point of view the naming itself is not unclear or subject to error, as long as it is consistent and suitably explained in the wiki docs).

@pkorolo
Panagiotis Korologos (pkorolo) marked this pull request as draft June 1, 2023 07:22
@pkorolo
Panagiotis Korologos (pkorolo) marked this pull request as ready for review June 6, 2023 13:03
@pkorolo
Copy link
Copy Markdown
Contributor Author

Arjen Huitema (@arjenhuitema) please review the proposed changes in the deployment variable names, if they are now satisfactory and alleviate confusion with parameter(s). If still needed, I can also alter the "parPolicyManagementGroupId" parameter name, as it appears (only) in the respective initiative assignment templates and the respective parameter files.
cc Jan Faurskov (@jfaurskov)

@pkorolo
Panagiotis Korologos (pkorolo) commented Jun 8, 2023 •
Copy link
Copy Markdown
Contributor Author

re-drafting to include parameter "parPolicyManagementGroupId" name change to "parPolicyPseudoRootMgmtGroup"

@pkorolo
Panagiotis Korologos (pkorolo) marked this pull request as draft June 8, 2023 13:32
@pkorolo
Panagiotis Korologos (pkorolo) marked this pull request as ready for review June 8, 2023 15:32
@pkorolo
Copy link
Copy Markdown
Contributor Author

Arjen Huitema (@arjenhuitema) I have finalized my PR with all requested changes; please review

cc Jan Faurskov (@jfaurskov) , just fyi

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work!

@arjenhuitema
Arjen Huitema (arjenhuitema) merged commit ad86b1a into Azure:main Jun 9, 2023
@pkorolo
Panagiotis Korologos (pkorolo) deleted the branchFor28605 branch June 12, 2023 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0