-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial DummySource and DummySensor conversion to Flatbuffers #82
Open
ClemensLinnhoff
wants to merge
15
commits into
master
Choose a base branch
from
feature/flatbuffers_examples
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClemensLinnhoff
added
the
suggestions
I just want to drop by and leave this suggestion to think about.
label
Feb 1, 2022
ClemensLinnhoff
force-pushed
the
feature/flatbuffers_examples
branch
from
February 4, 2022 18:57
9462d0b
to
e9108c4
Compare
Signed-off-by: linnhoff <linnhoff@persival.de>
Signed-off-by: linnhoff <linnhoff@fzd.tu-darmstadt.de>
Signed-off-by: linnhoff <linnhoff@fzd.tu-darmstadt.de>
ClemensLinnhoff
force-pushed
the
feature/flatbuffers_examples
branch
from
February 4, 2022 19:04
e9108c4
to
8c5d7e1
Compare
Signed-off-by: linnhoff <linnhoff@fzd.tu-darmstadt.de>
ClemensLinnhoff
force-pushed
the
feature/flatbuffers_examples
branch
from
February 4, 2022 19:07
8c5d7e1
to
7f5a0a7
Compare
Signed-off-by: linnhoff <linnhoff@fzd.tu-darmstadt.de>
Signed-off-by: linnhoff <linnhoff@fzd.tu-darmstadt.de>
PhRosenberger
force-pushed
the
feature/flatbuffers_examples
branch
2 times, most recently
from
February 18, 2022 15:43
4cf8c4c
to
c2bf776
Compare
Signed-off-by: PhRosenberger <philipp.rosenberger@tu-darmstadt.de>
Signed-off-by: PhRosenberger <philipp.rosenberger@tu-darmstadt.de>
PhRosenberger
force-pushed
the
feature/flatbuffers_examples
branch
from
February 18, 2022 15:56
c2bf776
to
f936b68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: linnhoff linnhoff@persival.de
Description
This is the first implementation of OSMPDummySource and OSMPDummySensor for Flatbuffers as a decision guide for a potential switch from Protobuf to Flatbuffers in OSI 4.0. There are still some open points marked with "todo" in the code. They include mainly the following:
Check the checklist