[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial DummySource and DummySensor conversion to Flatbuffers #82

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

ClemensLinnhoff
Copy link
Contributor

Signed-off-by: linnhoff linnhoff@persival.de

Description

This is the first implementation of OSMPDummySource and OSMPDummySensor for Flatbuffers as a decision guide for a potential switch from Protobuf to Flatbuffers in OSI 4.0. There are still some open points marked with "todo" in the code. They include mainly the following:

  1. Object type and vehicle classification are not correctly set in the generated Flatbuffers header files. Classification type is confused with vehicle type and the object types of moving and stationary object are interchanged. This is done by the flatc compiler, that generates the header files out of the .proto files.
  2. The interface version is not set at the moment. This is originally done by using Protobuf FileOptions, which do not exist in Flatbuffers.
  3. In the DummySensor, the input sensor_view is not copied into the sensor_data buffer in the initial commit. Copying buffer contents is not directly supported by Flatbuffers. Copying the offsets does not work, because they are not accessible, once the buffer is serialized (once a builder is finished). A deep copy of the object would work, but has do be done manually. There is no predefined function in Flatbuffers.

Check the checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation for osi-sensor-model-packaging.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / Github Actions pass locally with my changes.

@ClemensLinnhoff ClemensLinnhoff added the suggestions I just want to drop by and leave this suggestion to think about. label Feb 1, 2022
linnhoff added 3 commits February 4, 2022 20:01
Signed-off-by: linnhoff <linnhoff@persival.de>
Signed-off-by: linnhoff <linnhoff@fzd.tu-darmstadt.de>
Signed-off-by: linnhoff <linnhoff@fzd.tu-darmstadt.de>
Signed-off-by: linnhoff <linnhoff@fzd.tu-darmstadt.de>
Signed-off-by: linnhoff <linnhoff@fzd.tu-darmstadt.de>
Signed-off-by: linnhoff <linnhoff@fzd.tu-darmstadt.de>
@PhRosenberger PhRosenberger force-pushed the feature/flatbuffers_examples branch 2 times, most recently from 4cf8c4c to c2bf776 Compare February 18, 2022 15:43
Signed-off-by: PhRosenberger <philipp.rosenberger@tu-darmstadt.de>
Signed-off-by: PhRosenberger <philipp.rosenberger@tu-darmstadt.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestions I just want to drop by and leave this suggestion to think about.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants