Repository navigation
[16.0][FIX] shopfloor: handle multiple move lines in location content transfer - #1303
Open
nicolas-delbovier-acsone wants to merge 1 commit into
Conversation
Contributor
|
Hi @jbaudoux, @mmequignon, @TDu, @sebalix, @simahawk, |
nicolas-delbovier-acsone
force-pushed
the
16.0-fix-shopfloor-location-content-transfer-handle-multiple-move-lines-for-one-move
branch
from
October 16, 2026 14:55
41ac2a6 to
9f4f1d8
Compare
Co-authored-by: Jacques-Etienne Baudoux <je@bcim.be>
nicolas-delbovier-acsone
force-pushed
the
16.0-fix-shopfloor-location-content-transfer-handle-multiple-move-lines-for-one-move
branch
from
October 16, 2026 14:59
9f4f1d8 to
5484fd7
Compare
jbaudoux
reviewed
Oct 16, 2026
Contributor
There was a problem hiding this comment.
Your fix for the 2 move lines cases looks good.
However, for the partial quantity, there is another call missing to split the move line.
Comment on lines
+922
to
924
| # ↓ Necessary in case of partial because `qty_done = move_line.reserved_uom_qty` | ||
| # since we made a "mark_move_line_as_picked" | ||
| move_line.qty_done = quantity |
Contributor
There was a problem hiding this comment.
If you decrease the quantity, we need to split the move line for the processed quantity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix premature auto-validation of sibling move lines in
location_content_transferProblem
When processing transfers via the Location Content Transfer service in "process by line" mode (
go_to_single), validating a singlestock.move.lineinvokedstock.validate_moves(move_line.move_id).If a single
stock.movecontained multiplestock.move.linerecords (such as when demand is satisfied across multiple lots), validating the parentmove_idcaused Odoo to validate all related move lines at once. As a result, completing the first scanned line automatically completed remaining sibling lines without requiring the operator to scan them in Shopfloor.