Repository navigation
Conversation
Contributor
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Confidence score: 2/5
20261104120000_drop_old_getting_started.cjscan make pre-#8165 instances fail during rollout, and the migration cannot be reverted. Keep it out of the same stacked merge as #8165.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/database/lib/migrations/20261104120000_drop_old_getting_started.cjs">
<violation number="1" location="packages/database/lib/migrations/20261104120000_drop_old_getting_started.cjs:7">
P1: This migration runs on server boot and cannot be reverted, so it must not ship in the same stacked merge as #8165. The pre-#8165 instances still reading these tables will fail during rollout. Hold this PR out of the stack merge until #8165 is live in production.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
| * @param {import('knex').Knex} knex | ||
| */ | ||
| exports.up = async function (knex) { | ||
| await knex.schema.dropTableIfExists('getting_started_progress'); |
Contributor
There was a problem hiding this comment.
P1: This migration runs on server boot and cannot be reverted, so it must not ship in the same stacked merge as #8165. The pre-#8165 instances still reading these tables will fail during rollout. Hold this PR out of the stack merge until #8165 is live in production.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/database/lib/migrations/20261104120000_drop_old_getting_started.cjs, line 7:
<comment>This migration runs on server boot and cannot be reverted, so it must not ship in the same stacked merge as #8165. The pre-#8165 instances still reading these tables will fail during rollout. Hold this PR out of the stack merge until #8165 is live in production.</comment>
<file context>
@@ -0,0 +1,17 @@
+ * @param {import('knex').Knex} knex
+ */
+exports.up = async function (knex) {
+ await knex.schema.dropTableIfExists('getting_started_progress');
+ await knex.schema.dropTableIfExists('getting_started_meta');
+
</file context>
Contributor
Author
There was a problem hiding this comment.
Won't merge with the stack. I've only put it on the stack for visibility
kaposke
marked this pull request as ready for review
November 4, 2026 15:37
kaposke
force-pushed
the
gui/NAN-7976/chore-drop-old-getting-started
branch
from
November 4, 2026 20:17
8162582 to
4e35759
Compare
kaposke
force-pushed
the
gui/NAN-7976/chore-drop-old-getting-started
branch
from
November 5, 2026 13:46
4e35759 to
7793454
Compare
kaposke
force-pushed
the
gui/NAN-7976/chore-drop-old-getting-started
branch
from
November 5, 2026 13:48
7793454 to
cd0d266
Compare
kaposke
force-pushed
the
gui/NAN-7976/chore-drop-old-getting-started
branch
from
November 5, 2026 14:27
cd0d266 to
faaa73a
Compare
kaposke
force-pushed
the
gui/NAN-7976/chore-drop-old-getting-started
branch
from
November 5, 2026 15:58
faaa73a to
453446d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differe
6FF0
ntly than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of NAN-7976. Drops the storage the old Getting started flow used. Nothing reads it since #8165.
getting_started_progressandgetting_started_metatables._nango_users.getting_started_closedand itsDBUserfield.Merge only once #8165 is deployed. The server that's live before it still reads and writes these, so dropping them earlier breaks it during the rollout. This can't be undone: the data is gone and the
downis empty.