-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BoilerHotWater: on cycle name change #4985
Conversation
src/energyplus/ForwardTranslator/ForwardTranslateBoilerHotWater.cpp
Outdated
Show resolved
Hide resolved
@@ -13732,7 +13732,7 @@ OS:Boiler:HotWater, | |||
\units W | |||
\ip-units W | |||
\minimum 0.0 | |||
\default 0.0 | |||
\required-field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
if ((value = modelObject.parasiticElectricLoad())) { | ||
idfObject.setDouble(Boiler_HotWaterFields::OnCycleParasiticElectricLoad, value.get()); | ||
} | ||
idfObject.setDouble(Boiler_HotWaterFields::OnCycleParasiticElectricLoad, modelObject.onCycleParasiticElectricLoad()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect
if ((value = modelObject.offCycleParasiticFuelLoad())) { | ||
idfObject.setDouble(Boiler_HotWaterFields::OffCycleParasiticFuelLoad, value.get()); | ||
} | ||
idfObject.setDouble(Boiler_HotWaterFields::OffCycleParasiticFuelLoad, modelObject.offCycleParasiticFuelLoad()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this one too
CI Results for 0b79413:
|
tested locally, all good. no point waiting. |
Pull request overview
Pull Request Author
src/model/test
)src/energyplus/Test
)src/osversion/VersionTranslator.cpp
)Labels:
IDDChange
APIChange
Pull Request - Ready for CI
so that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.