-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4897 - openstudiolib.dll/libopenstudiolib.so not found without C++ API Component selected in IFW #4900
Conversation
…udiolib as part of the CLI component for IFW
CI Results for b67f9cc:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 🪟 Windows 10.
- 🐈 Ubuntu 22.04 haven't tried it but can if needed.
Looks like there are two errors for the Windows build; one unrelated, one related.
2249/3807 Test #2251: ModelFixture.ScheduleFile ..........................................................................................................................................................................................................***Failed 0.17 sec
Running main() from C:\J\w\BuildSingleReference@4\.conan\data\gtest\1.11.0\_\_\build\5ad274d83035c78ba2b205e6cf4f1b317aee8e05\source_subfolder\googletest\src\gtest_main.cc
Note: Google Test filter = ModelFixture.ScheduleFile
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from ModelFixture
[ RUN ] ModelFixture.ScheduleFile
D:\git\OpenStudio\src\model\test\ScheduleInterval_GTest.cpp(264): error: Value of: externalfile
Actual: false
Expected: true
[ FAILED ] ModelFixture.ScheduleFile (59 ms)
[----------] 1 test from ModelFixture (59 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (60 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] ModelFixture.ScheduleFile
1 FAILED TEST
3635/3807 Test #3642: OpenStudioCLI.Labs.test_logger_rb ..................................................................................................................................................................................................***Failed 1.64 sec
Namespace(labs=True, logger_file=WindowsPath('D:/git/OpenStudio/src/cli/test/logger_test.rb'), os_cli_path=WindowsPath('D:/git/OpenStudio/build/Products/openstudio.exe'))
Running: D:\git\OpenStudio\build\Products\openstudio.exe labs execute_ruby_script D:\git\OpenStudio\src\cli\test\logger_test.rb
0 [test] <0> Warn
1 [test] <1> Error
2 [test] <1> Error
3 LOGGER - STDOUT Warn
4 LOGGER - STDOUT Error
Traceback (most recent call last):
File "D:/git/OpenStudio/src/cli/test/run_test_logger.py", line 54, in <module>
raise IOError(f"Expected 3 lines, got {n}")
OSError: Expected 3 lines, got 5```
None are related. We need to fix these tests, it's annoying to have to dig through to see if it's something new or something broken already |
Pull request overview
Pull Request Author
src/model/test
)src/energyplus/Test
)src/osversion/VersionTranslator.cpp
)Labels:
IDDChange
APIChange
Pull Request - Ready for CI
so that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.