Repository navigation
Conversation
This variable is declared as const, but assigned in `source/blood/src/blood.cpp`. Leads to compilation error with `STANDALONE=1`.
Member
|
Your fix is wrong. There is no reason to edit engine files for this. Fixing the compilation failure would involve the game code. If you don't know what At present it has nothing to do with Blood. It has to do with building an executable suitable for commercial releases such as Ion Fury. |
Author
|
hi! I didn't look very deeply into it, since I was just testing different compilation options. Figured proposing something is at least as useful as a bug report should there be a check to only assign the variable if standalone is off? |
Author
|
or, are you saying the option shouldn't ever be used and isn't expected to work? you can close in that case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This variable is declared as const, but assigned in
source/blood/src/blood.cpp. Leads to compilation error withSTANDALONE=1.Hi! I don't actually know what the standalone version is.