Repository navigation
store: WAL journaling so streamed deltas commit cheaply - #24
Merged
Merged
Conversation
Root cause of the flaky Windows CI failure in the inspector tests: every streamed delta is its own committed event, and with SQLite's default rollback journal and `synchronous = FULL` each commit waited for the disk (10.8 ms per delta on a fast local SSD, far more on a busy CI runner with several workspaces streaming at once). The four tests that ran their workspaces in parallel exceeded their inference deadline together; the one that ran after them passed. File stores now use WAL with `synchronous = NORMAL`: a commit appends to the log without waiting for the disk (0.16 ms per delta locally, about 68x faster), the database cannot be corrupted, and at worst the last moments before a power failure are lost (such a run is failed as interrupted on restart). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the flaky Windows CI failure seen on
da25a12(inspector tests).Root cause: every streamed delta is its own committed event. With SQLite's default journal and
synchronous = FULL, each commit waits for the disk: 10.8 ms per delta on a fast local SSD, and much more on a busy CI runner. The four inspector tests that run their workspaces in parallel exceeded their inference deadline together (all failed about 24 s in). The fifth test, which ran after them, passed.Fix: file stores use WAL with
synchronous = NORMAL. Commits no longer wait for the disk: 0.16 ms per delta locally, about 68× faster. The database cannot be corrupted, and at worst the last moments before a power failure are lost; such a run is marked interrupted on restart. A new test checks that file stores commit through the log and survive a restart. The earlier hardening (tests no longer read real saved keys, a longer deadline, and failures that say why) stays.🤖 Generated with Claude Code