8000 feat: Complete core scene flow (closes #2) by Mnehmos · Pull Request #53 · Mnehmos/corehold · GitHub
[go: up one dir, main page]

Skip to content

feat: Complete core scene flow (closes #2) - #53

Merged
Mnehmos merged 1 commit into
mainfrom
issue-2/core-scene-flow
May 3, 2026
Merged

Mnehmos merged 1 commit into
mainfrom
issue-2/core-scene-flow

Conversation

@Mnehmos
@Mnehmos Mnehmos commented May 3, 2026
Copy link
Copy Markdown
Owner

Summary

Completes Issue #2 — Add Core Scene Flow by filling the missing link between the Game scene and RunSummary scene.

Problem

The initial scaffold had all three scenes (MainMenu, Game, RunSummary) but the Game scene had no way to transition to RunSummary. Players would be stuck in the Game scene indefinitely with no game-over trigger or exit button. Additionally, the Game scene used local variables instead of the RunState singleton, and RunSummary displayed static placeholder text instead of actual run data.

Changes

File Change
scenes/Game.tscn Added "End Run" button anchored to bottom-right of HUD
scripts/ui/Game.gd Replaced local vars with RunState singleton; added _end_run() that emits EventBus.run_ended, records stats via GameState.record_run, and transitions to RunSummary
scripts/ui/RunSummary.gd Added _populate_stats() to read run data from RunState and populate all labels dynamically
scripts/ui/MainMenu.gd No functional change (Start Run already works correctly)

Acceptance Criteria Verification

  • Player can start a run from the main menu — StartButton transitions to Game.tscn
  • Player can reach a placeholder run summary — End Run button transitions to RunSummary.tscn
  • Player can return to main menu — Main Menu button transitions back to MainMenu.tscn

Scene Flow

MainMenu -> [Start Run] -> Game -> [End Run] -> RunSummary -> [Main Menu] -> MainMenu
                                              -> [Restart]  -> Game

Closes #2

- Add End Run button to Game.tscn HUD for placeholder run ending
- Refactor Game.gd to use RunState/GameState singletons instead of local vars
- Emit EventBus.run_ended and record run stats via GameState.record_run
- Populate RunSummary labels from RunState singleton data
- Full flow: MainMenu → Game (Start Run) → RunSummary (End Run) → MainMenu
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai
coderabbitai Bot commented May 3, 2026
Copy link
Copy Markdown

Warning

Rate limit exceeded

@Mnehmos has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 40 minutes and 16 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d73d716b-8580-42ab-ad2e-89bacb1d4293

📥 Commits

Reviewing files that changed from the base of the PR and between 5fd2024 and a03358c.

📒 Files selected for processing (3)
  • scenes/Game.tscn
  • scripts/ui/Game.gd
  • scripts/ui/RunSummary.gd
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-2/core-scene-flow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 40 minutes and 16 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

This was referenced May 3, 2026
@Mnehmos
Mnehmos merged commit 41173c4 into main May 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Core Scene Flow

1 participant

0