8000 Add canonical pedagogy workflow by Mnehmos · Pull Request #49 · Mnehmos/MathOS · GitHub
[go: up one dir, main page]
Skip to content

Add canonical pedagogy workflow - #49

Merged
Mnehmos merged 2 commits into
mainfrom
issue-48-canonical-pedagogy
Jul 21, 2026
Merged

Add canonical pedagogy workflow#49
Mnehmos merged 2 commits into
mainfrom
issue-48-canonical-pedagogy

Conversation

@Mnehmos
@Mnehmos Mnehmos commented Jul 21, 2026 •
edited by coderabbitai Bot
Loading
Copy link
Copy Markdown
Owner

Summary

  • add the closed Rust-owned learning_unit/1 contract and committed JSON Schema for all SPEC pedagogy fields and unit kinds
  • enforce exact current grounding, verified content/license policy, controlled immutable review, training eligibility, and prerequisite payload/edge parity
  • expose shared CLI/MCP propose, version, get, validate, review, link, and deterministic bounded path actions
  • require external taxonomy crosswalks to preserve an exact current source and its exact license

Playtest

The fresh-root CLI integration creates and reviews explanation, counterexample, misconception, exercise, and mastery-check units; exercises dry-run/retry, incomplete-link rejection, prerequisite and recommended paths, restart, stale grounding, public-training rejection, and taxonomy-license rejection.

A separate process-per-action CLI run on the preserved Pilot A repaired-claim ledger traversed the five reviewed kinds in order against:

  • source 019f868e-463d-7103-9cc3-222213939c55@59ef27897c032cab17d1c371f509ab05898a65bef03376e5deb33d18822c8c40
  • repaired claim 019f868e-464e-78e0-9125-035f7fba0e87@288e4ee259fb2f7cb5fd5295c971fec10ee85415601d6ea13d7d09d3103a6ddc
  • Lean formalization 019f868e-4662-7bc0-ba7b-b1b6d1214e05@527785065de148fc1ba15f4001afcce41a1e4bf10d0fee33c3de157df8b7afc5

Derived claim status was unchanged by pedagogy review, and mcl doctor remained healthy.

Verification

  • cargo fmt --check
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • cargo test --workspace (141 unit, 1 Lean worker, 4 MCP, 13 CLI)
  • PYTHONPATH=src PYTHONWARNINGS=error::ResourceWarning python -m unittest discover -s tests -v (39 passed)
  • focused fresh-root and preserved-ledger CLI playtests
  • git diff --check

Closes #48

Summary by CodeRabbit

  • New Features

    • Added canonical learning units with structured content, prerequisites, references, review states, licensing, and training eligibility.
    • Added CLI and MCP pedagogy tools for proposing, versioning, validating, reviewing, linking, and exploring learning paths.
    • Added deterministic prerequisite and recommended-learning path queries with validation of references, licenses, and content.
    • Added taxonomy crosswalk validation, including duplicate detection and license checks.

  • Documentation

    • Documented the pedagogy trust model, versioning and review process, architecture decisions, and release evidence.

  • Bug Fixes

    • Tightened taxonomy license-expression size limits and rejected stale, invalid, or mismatched references.

@coderabbitai
coderabbitai Bot commented Jul 21, 2026 •
edited
Loading
Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@Mnehmos, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 48 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: eb833f29-07f4-47da-9aa0-f7591d1d6a5c

📥 Commits

Reviewing files that changed from the base of the PR and between 2f44628 and d85be14.

📒 Files selected for processing (3)
  • src/app.rs
  • src/store/mod.rs
  • tests/phase1_cli.rs
📝 Walkthrough

Walkthrough

Adds version-bound learning_unit/1 records with schema and policy validation, controlled review, typed pedagogy links, deterministic prerequisite paths, CLI/MCP operations, persistence checks, integration tests, and documentation.

Changes

Canonical pedagogy

Layer / File(s) Summary
Learning-unit contract and validation model
schemas/pedagogy/..., src/domain/schemas.rs, schemas/concept/..., docs/decisions/...		 Defines the closed learning-unit payload, generated and committed schema, exact references, review/training states, bounded fields, and taxonomy license validation.
Application and stored-reference enforcement
src/app.rs, src/store/mod.rs		 Adds learning-unit creation, review, dependency validation, artifact and license checks, typed pedagogy links, and deterministic reviewed-path computation.
CLI and MCP pedagogy operations
src/cli/mod.rs, src/mcp/mod.rs		 Adds propose, version, get, validate, review, link, and path operations with typed parsing, bounded traversal, capability advertisement, and strict request-field validation.
CLI/MCP lifecycle verification
tests/phase1_cli.rs, tests/mcp_stdio.rs		 Covers proposal, review, validation, prerequisite paths, restart persistence, stale references, training restrictions, and taxonomy license failures.
Architecture and implementation records
docs/trust/..., docs/implementation/..., docs/dev-diary/...		 Records the learning-unit decision, pedagogy trust model, implementation evidence, release checklist updates, and lesson essay.

Estimated code review effort: 4 (Complex) | ~60 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CLI
  participant MCP
  participant Application
  participant Store
  CLI->>Application: propose or review learning unit
  MCP->>Application: execute pedagogy action
  Application->>Store: validate references and persist version
  Application->>Store: resolve reviewed pedagogy edges
  Store-->>Application: records and edges
  Application-->>CLI: validation
8000
 or path snapshot
  Application-->>MCP: validation or path snapshot
Loading
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the feature, but it omits most required template sections like Change class, TDD evidence, Mathematical verification, Provenance, Risk, and Review readiness. Complete the template sections for Change class, TDD evidence, Mathematical verification, Provenance and licensing, Risk and recovery, and Review readiness.
Docstring Coverage ⚠️ Warning Docstring coverage is 16.09% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and directly reflects the main change: adding a canonical pedagogy workflow.
Linked Issues check ✅ Passed The PR matches #48 by adding the closed learning_unit schema, validation, CLI/MCP pedagogy actions, deterministic paths, tests, and docs.
Out of Scope Changes check ✅ Passed All added code and docs support canonical pedagogy, validation, paths, and tests; no unrelated out-of-scope change is apparent.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-48-canonical-pedagogy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Mnehmos
Mnehmos marked this pull request as ready for review July 21, 2026 22:50
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 21, 2026
View reviewed changes
@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2f4462822c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/app.rs Resolved
@Mnehmos
Mnehmos merged commit 6764ac2 into main Jul 21, 2026
6 checks passed
This was referenced Jul 21, 2026
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Phase 5: canonical pedagogy records and Pilot A curriculum path

1 participant

@Mnehmos
0