8000 fix: align zero-to-one release with v1.0.0 by Mnehmos · Pull Request #3 · Mnehmos/MathOS · GitHub
[go: up one dir, main page]
Skip to content

fix: align zero-to-one release with v1.0.0 - #3

Merged
Mnehmos merged 2 commits into
mainfrom
fix/v1-release-semantics
Jul 19, 2026
Merged

fix: align zero-to-one release with v1.0.0#3
Mnehmos merged 2 commits into
mainfrom
fix/v1-release-semantics

Conversation

@Mnehmos
@Mnehmos Mnehmos commented Jul 19, 2026 •
edited by coderabbitai Bot
Loading
Copy link
Copy Markdown
Owner

Summary

Correct the release semantics so the completed 0-to-1 product specification culminates in MathOS v1.0.0.

The required product capabilities and explicit non-goals are unchanged. This does not broaden or reduce the accepted scope. It corrects the package, CLI, MCP, trust model, release ledger, implementation evidence, and public diary to use the product owner's intended 1.0 boundary.

Evidence

  • 39 tests pass with ResourceWarning promoted to an error
  • 13 dedicated adversarial scenarios pass
  • 200 deterministic randomized claims match an independent oracle
  • CLI and MCP both report 1.0.0
  • clean wheel mnehmos_mathos-1.0.0 installs and passes pip check
  • canonical proved, disproved, and unresolved outcomes pass
  • every generated RL trajectory validates
  • git diff --check passes

Definition of Done

The v1.0.0 tag must target the exact main commit produced after this correction is reviewed and merged.

Dev Diary

Adds GPT-5.6 Sol Dev Diary entry 04, "The Name of Done," recording the framing error and correction.

Summary by CodeRabbit

  • Release

    • MathOS is now identified as version 1.0.0 throughout the product and verification interfaces.
    • The CLI and server handshake now report version 1.0.0.

  • Documentation

    • Updated product, architecture, release criteria, and evidence documentation to describe the v1.0 release.
    • Added a development diary entry documenting the completion of MathOS 1.0.

  • Tests

    • Added coverage confirming version reporting across the CLI and server handshake.

@coderabbitai
coderabbitai Bot commented Jul 19, 2026 •
edited
Loading
Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@Mnehmos, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0a32a597-a6b9-4b09-9f06-3be65433cb30

📥 Commits

Reviewing files that changed from the base of the PR and between 8ad9744 and 8afd37e.

📒 Files selected for processing (1)
  • docs/product/ZERO_TO_ONE_DOD.md
📝 Walkthrough

Walkthrough

MathOS version references were updated from v0.1 to v1.0 across package metadata, runtime reporting, verifier evidence, tests, release records, architecture documentation, and development diary entries.

Changes

MathOS 1.0 release alignment

Layer / File(s) Summary
Runtime version contract and verification
pyproject.toml, src/mathos/__init__.py, src/mathos/lean.py, tests/test_cli.py, tests/test_mcp.py		 Package, module, verifier, CLI, and MCP version values now report 1.0.0, with CLI and handshake assertions covering the updated value.
Release evidence and completion records
docs/implementation/..., docs/product/SPEC.md, docs/product/ZERO_TO_ONE_DOD.md		 Release evidence and completion criteria now reference MathOS 1.0, including updated test totals, tagging instructions, and release-correction status.
Architecture and release framing
README.md, docs/architecture/..., docs/dev-diary/...		 README, trust model, ADR status, and development diary documentation now describe the v1.0 system and release.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • Mnehmos/MathOS#2: Updates the established v0.1.0 lifecycle and version constants to v1.0.0.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description omits most required template sections, including change class, TDD evidence, mathematical verification, provenance, risk, and review readiness. Fill in every required template section with the requested checklists, evidence, commands/results, provenance, risks, and review-readiness status.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the release-version alignment change to v1.0.0.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/v1-release-semantics

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Mnehmos
Mnehmos merged commit 49b8657 into main Jul 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Mnehmos
0