8000 Fix supported Windows workstation validation by Mnehmos · Pull Request #29 · Mnehmos/MathOS · GitHub
[go: up one dir, main page]
Skip to content

Fix supported Windows workstation validation - #29

Merged
Mnehmos merged 1 commit into
mainfrom
fix/windows-workstation-validation
Jul 20, 2026
Merged

Fix supported Windows workstation validation#29
Mnehmos merged 1 commit into
mainfrom
fix/windows-workstation-validation

Conversation

@Mnehmos
@Mnehmos Mnehmos commented Jul 20, 2026
Copy link
Copy Markdown
Owner

Product outcome

Make the documented home-workstation checks deterministic and exercise the real pinned Lean worker and audit lifecycle on supported Windows.

Changes

  • derive the integration environment from the actual host platform and use its computed canonical hash throughout the exact lifecycle
  • make missing-Lean coverage independent of the machine's PATH
  • close direct SQLite tampering connections before Windows temporary-directory cleanup
  • retain a detailed worker outcome on integration assertion failure

Local evidence

  • MCL_RUN_LEAN_INTEGRATION=1 cargo test --test lean_worker -- --nocapture passed with Lean 4.32.0 on Windows
  • all 39 legacy Python regressions passed with ResourceWarnings denied
  • formatting and warnings-denied Clippy passed
  • cargo test --workspace passed (89 tests)
  • git diff --check passed

Closes #28
Refs #21
Refs #25

@coderabbitai
coderabbitai Bot commented Jul 20, 2026
Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5f6d31aa-a32f-402e-a0c1-1a32c67463f1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/windows-workstation-validation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Mnehmos
Mnehmos marked this pull request as ready for review July 20, 2026 00:47
@Mnehmos
Mnehmos merged commit 824ad46 into main Jul 20, 2026
6 checks passed
@Mnehmos
Mnehmos deleted the fix/windows-workstation-validation branch July 20, 2026 00:47
@coderabbitai
coderabbitai Bot commented Jul 20, 2026
Copy link
Copy Markdown

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details 
No server is currently available to service your request. Sorry about that. Please try resubmitting your request and contact us if the problem persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix supported Windows workstation verifier and legacy regressions

1 participant

@Mnehmos
0