8000 fix: retain rejected attestation challenges by Mnehmos · Pull Request #24 · Mnehmos/MathOS · GitHub
[go: up one dir, main page]
Skip to content

fix: retain rejected attestation challenges - #24

Merged
Mnehmos merged 1 commit into
mainfrom
fix/publication-attestation-selector
Jul 20, 2026
Merged

fix: retain rejected attestation challenges#24
Mnehmos merged 1 commit into
mainfrom
fix/publication-attestation-selector

Conversation

@Mnehmos
@Mnehmos Mnehmos commented Jul 19, 2026
Copy link
Copy Markdown
Owner

Fixes the exact failure observed in protected publication run 29708636210.

Root cause

GitHub CLI 2.96.0 rejects simultaneous --cert-identity and --signer-workflow selectors as mutually exclusive. The run reached pinned tool installation, isolated Lean verification, and Sigstore attestation before failing at that argument contract.

Focused correction

  • keep the stronger exact certificate SAN constraint
  • remove only the redundant signer-workflow selector
  • keep exact repository, source ref, source digest, signer digest, predicate, bundle, and hosted-runner constraints
  • capture verifier stderr as retained evidence
  • run artifact retention with always() so failed challenges remain visible

Evidence

  • exact local and remote tree: 6c1396d3620405f0bb33a469e185b55c8080ad56
  • shell syntax passes
  • the prior retained bundle now reaches Sigstore verifier initialization instead of CLI flag rejection
  • the unavailable local trusted-root path exits with stable code 70 and retains raw output plus verifier stderr
  • formatting and patch checks pass

No authority is created by this correction.

@Mnehmos
fix: retain rejected attestation challenges
68539d1 
Use the exact certificate identity selector without the mutually exclusive signer-workflow flag, capture verifier diagnostics, and retain evidence even when the challenge fails.
@coderabbitai
coderabbitai Bot commented Jul 19, 2026
Copy link
Copy Markdown

Warning

Review limit reached

@Mnehmos, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 31 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4980443b-37c3-483e-ab37-6ef4a36f9362

📥 Commits

Reviewing files that changed from the base of the PR and between 47346cd and 68539d1.

📒 Files selected for processing (6)
  • .github/workflows/publication.yml
  • docs/decisions/ADR-0006-oidc-attested-publication-authority.md
  • docs/dev-diary/0033-a-failed-challenge-must-leave-a-trace.md
  • docs/dev-diary/README.md
  • docs/implementation/STATUS.md
  • scripts/publication-attestation-verify.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/publication-attestation-selector

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Mnehmos
Mnehmos merged commit cb03113 into main Jul 20, 2026
6 checks passed
@Mnehmos Mnehmos mentioned this pull request Jul 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Mnehmos
0