[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: do not set C(XX)FLAGS for rvv #55

Merged
merged 3 commits into from
Jul 20, 2023
Merged

chore: do not set C(XX)FLAGS for rvv #55

merged 3 commits into from
Jul 20, 2023

Conversation

xhebox
Copy link
Collaborator
@xhebox xhebox commented Jul 19, 2023

Some users report that they want to set -march freely for performance tunning. Thus, now, the enforcement of flags are removed.

@xhebox
chore: do not set C(XX)FLAGS for rvv
6b1b356 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from chenqy4933 July 19, 2023 13:39
@xhebox
fix
6195417 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
fix
48054a2 
Signed-off-by: xhe <xw897002528@gmail.com>
@chenqy4933
Copy link
Collaborator

its better to rebase all the commit to one

@chenqy4933
Copy link
Collaborator

LGTM

@xhebox
Copy link
Collaborator Author
xhebox commented Jul 20, 2023 •
edited
Loading

its better to rebase all the commit to one

You can disable other two merge methods on github. And always merge with squash and merge, which will merge all commits into one automatically.

@xhebox xhebox merged commit b8f7cc3 into MegEngine:main Jul 20, 2023
@xhebox xhebox deleted the rv64 branch July 20, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenqy4933 chenqy4933 Awaiting requested review from chenqy4933

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xhebox @chenqy4933