Repository navigation
Fix UB in ogg_sync_pageseek before any data is buffered - #118
Open
StephaniePinkish wants to merge 1 commit into
Open
StephaniePinkish wants to merge 1 commit into
StephaniePinkish wants to merge 1 commit into
Conversation
oy->data is NULL until the first ogg_sync_buffer(), so return 0 (need more data) instead of offsetting a null pointer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until the first
ogg_sync_buffer()call,oy->datais NULL, soogg_sync_pageseek()computesoy->data+oy->returnedon a null pointer. With-fsanitize=undefined, clang reports:libvorbis's vorbisfile calls this on every open, before it has fed any data, so any sanitized application that decodes Vorbis hits it. 7cf42ea moved this computation after
ogg_sync_check(), but that check passes whiledatais still NULL.Minimal reproduction:
The fix returns 0 ("need more data") when there is no buffer yet. That is what the function already returns for an empty buffer, so callers see no change. The commit adds a self-test for this case to
test_framing.