Repository navigation
Fix REST card overtime persistence - #6888
Merged
Merged
Conversation
Keep accepting the isOverTime request parameter and write its validated value to the isOvertime schema field used by card readers and the UI. Correct the handler regression and cover JSON/form edits, persistence, API reads, reactive display, reloads and rejected requests.
xet7
added a commit
that referenced
this pull request
Nov 10, 2026
…ime. #6888 makes the REST card PUT write its isOverTime parameter to the schema's isOvertime field. Every overtime set through the API before it - since b895e61 - was stored under isOverTime, which the UI and every reader ignore: those cards still show no overtime. A schema upgrade step, card-overtime-field, carries that over on the next start: isOverTime becomes isOvertime where the card has none, the value the UI already shows wins where it has both, and the stray field is removed. Two updateMany batches and an $unset, version-gated and idempotent like the steps beside it. tests/schemaUpgradeSteps.test.cjs pins the fold, the precedence and a second pass finding nothing; as negatives, no work on cards without the field, and - tree-wide - no server code writing isOverTime into a card. Thanks to AhmedLukman and xet7 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A card update with
{"isOverTime": true}returns HTTP 200 but leaves the saved overtime flag unchanged. The REST handler writesisOverTime, while the card schema and UI useisOvertime.Keep the existing request parameter and store its validated value in
isOvertime, using the same scoped, awaited update as neighboring fields. Correct the handler regression and add browser coverage for JSON/form updates, database persistence, independent API reads, reactive UI changes, reloads, and rejected requests.Validation: