Repository navigation
Persist auto-size mode per bin - #252
Merged
Merged
Conversation
Signed-off-by: Jason Madigan <jason@jasonmadigan.com>
Signed-off-by: Jason Madigan <jason@jasonmadigan.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reopening a bin enabled auto-size again and could replace a saved 2×1 grid with 3×1. Save the choice per bin and restore it before fitting tools.
Pin the E2E job to Ubuntu 24.04, which the installed Playwright version supports.
Closes #250.
Evidence
After: off/on survives reload and navigation; manual dimensions and tool positions are preserved.
make lint: passed, nine ESLint warnings in unchanged files.venv/bin/python -m pytest -q, 873 passed.pnpm test, 299 passed.make test-e2e-accuracy: 7 passed, including both persistence regressions.Merge Danger
Door: two-way. Existing bins default to auto-size on.
Blast Radius: bins. Adds a saved editor preference outside the geometry configuration.