Repository navigation
Enforce single-writer deployment settings - #240
Draft
noobydp wants to merge 1 commit into
Draft
noobydp wants to merge 1 commit into
noobydp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple backend processes sharing a storage volume can overwrite acknowledged saves because the JSON stores and generation locks are process-local. Pin the container to one Uvicorn worker even when a platform sets
WEB_CONCURRENCY, reject Helm replica counts above one, and document the single-writer requirement.The chart retains Recreate so a one-replica upgrade does not briefly run two writers. Source launches and separate containers sharing a volume remain an operator constraint; this change does not implement multi-process storage.
Closes #155 (the issue's minimum single-worker deployment scope).
Validation:
make lint: backend lint, frontend lint and TypeScript passed; 9 existing frontend warnings.WEB_CONCURRENCY=4and render the chart with default, 0, 1, 2 and 4 replicas. Helm runs in backend CI.Validation ran on macOS with Python 3.12, the repository-declared pnpm 10.29.2, and Helm 4.3.1. A full Docker image runtime smoke test was not run locally.