Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tool pockets can leave an overhang where they meet a stacking lip or raised rim. Some layouts also need a deliberate side opening for a tool or finger cutout.
Add Allow wall cutouts below Contrast Insert. With it on, tool outlines and finger cutouts that reach the outside can open the side wall, raised rim and stacking lip. With it off, the rounded inner wall clips both types of cutout and their chamfers. Overlapping pockets still clear the inside of the lip. Cutout depth is measured from the wall top, preserving the bin floor.
The toggle defaults to off for new bins and saved records that lack the setting. Enable it on existing bins that rely on finger cutouts opening through a side. The preference saves with the bin and can be saved as a global or project default. The bin sidebar is wider so the new label and help icon fit together.
Auto-size and bin creation reserve the configured wall thickness and clearance. Turn off Auto-size grid to hold the bin at a manual size for intentional side openings. This keeps the default wall protection from #120 and updates the fit calculation from #234.
Verification
python -m pytest -q --tb=shortfrombackendpassed all 891 tests. STL sections cover tool outlines and all five finger cutout shapes with the setting on and off, including the raised rim, stacking lip, floor and the wall outside each opening.pnpm testpassed all 299 tests.make lintpassed with nine existing frontend warnings.make test-e2e-accuracypassed all five browser-to-STL accuracy checks.