8000 build(deps): update frontend dependencies for security advisories by jasonmadigan · Pull Request #238 · tracefinity/tracefinity · GitHub
[go: up one dir, main page]

Skip to content

build(deps): update frontend dependencies for security advisories - #238

Merged
jasonmadigan merged 1 commit into
mainfrom
fix/frontend-security-advisories
Oct 24, 2026
Merged

jasonmadigan merged 1 commit into
mainfrom
fix/frontend-security-advisories

Conversation

@jasonmadigan
@jasonmadigan jasonmadigan commented Oct 24, 2026 •
Copy link
Copy Markdown
Collaborator

Summary

Next.js 16.3.8 (#236) does not fix GHSA-2464-fhr4-w9xw, GHSA-673q-mjm6-r5xr or GHSA-p3m5-59mp-jv5r. 16.4.1 is the first release with those fixes, and 16.4.3 adds backported bug fixes on top. This replaces #236 and #237.

 next     ^16.3.6  ^16.4.3
 vite     ^8.0.16  ^8.1.6
 vitest   ^4.1.11  ^4.1.12
 pnpm.overrides
-  brace-expansion@1  1.1.18
+  brace-expansion@1  ^1.1.21
-  brace-expansion@2  2.1.4
+  brace-expansion@2  ^2.1.7
-  jsdom@29>undici    7.29.0
+  jsdom@29>undici    ^7.30.1
-  undici             >=7.29.0
+  undici             >=7.30.1
-  js-yaml            >=4.3.1
+  js-yaml            >=5.4.1

The exact override pins were themselves vulnerable, and they stopped Dependabot and pnpm update from resolving the patched transitive versions. Ranges starting at the first patched version fix that. browserslist, source-map-js, fflate, zod, @humanfs/node and postcss-selector-parser are refreshed within their existing ranges.

frontend/pnpm-workspace.yaml sets minimumReleaseAge: 4320, so resolving new versions skips releases younger than three days. next and @next/* are excluded so security releases can be adopted the same day. Frozen installs (CI and Docker) do not re-check locked versions: a frozen install of a lockfile containing a one-day-old release still succeeds. Both Dockerfiles copy the file so image installs see the same pnpm settings.

One advisory remains: postcss-selector-parser GHSA-rj75-hqrm-r3gf is fixed only in 7.1.6, and tailwindcss 3.4.19 still requires ^6.1.2. Tailwind uses it to parse the project's own CSS at build time.

Evidence

  • Before: pnpm audit reports 48 advisories (2 critical, 16 high, 24 moderate, 6 low).
    After: 1 moderate (postcss-selector-parser, above).
  • Every package version added to the lockfile was published at least three days ago, except next and @next/* 16.4.3 (published with npm provenance). None of them has an install script.
  • In a node:20-slim container: eslint reports 0 errors (the same 9 warnings as main), tsc --noEmit passes, vitest passes 29 files and 275 tests.
  • A local arm64 docker build of this branch with fix(docker): install current Pillow and torch dependencies in the image #239 succeeds, and the container starts: GET / returns 200 through nginx, and GET /api/version returns 200 once the backend is up.

Merge Danger

Door: two-way

Blast Radius: frontend

Next.js moves from 16.3 to 16.4, a minor release that changes the production server and build. The e2e suite covers the upload, tracing and export flows.

Update Next.js to 16.4.3. 16.4.1 is the first release with fixes for
GHSA-2464-fhr4-w9xw, GHSA-673q-mjm6-r5xr and GHSA-p3m5-59mp-jv5r, and
16.4.x also carries the 16.3.8 fixes. Update Vite to 8.1.6 and Vitest to
4.1.12.

Several pnpm overrides pinned exact versions that are now vulnerable
(brace-expansion 1.1.18 and 2.1.4, undici 7.29.0 under jsdom), which
stopped the patched releases from resolving. Use ranges from the first
patched versions instead, raise the js-yaml and undici floors, and
refresh browserslist, source-map-js, fflate, zod, @humanfs/node and
postcss-selector-parser.

Add a three-day minimumReleaseAge so local resolution skips releases
published in the last three days. Next.js is excluded so security
releases can be adopted immediately. Frozen installs are unaffected.

Signed-off-by: Jason Madigan <jason@jasonmadigan.com>
@jasonmadigan
jasonmadigan merged commit fd35e9a into main Oct 24, 2026
6 checks passed
@jasonmadigan
jasonmadigan deleted the fix/frontend-security-advisories branch October 24, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0