Repository navigation
ref: Make error enum more fine-grained - #11
Merged
Merged
Conversation
This adds individual error enum variants for all operations that can fail. The intention is to make it easier to trace which operation produced a minidumper error in particular (the `io` and `CrashHandler` cases can only originate from one place anyway).
timfish
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds individual error enum variants for all operations that can fail. The intention is to make it easier to trace which operation produced a minidumper error in particular (the io and CrashHandler cases can only originate from one place anyway).
It also changes Server::start and Client::start to take OwnedSocketName instead of SocketName so that the socket name can be included in the error. This is not possible with SocketName because it doesn't implement Debug or Display.