Repository navigation
Campaign senders: show capacity after warmup - #36
Open
uzairahmed242 wants to merge 1 commit into
Open
uzairahmed242 wants to merge 1 commit into
uzairahmed242 wants to merge 1 commit into
Conversation
Warmup mail comes out of the same daily limit as campaign mail (planCampaign subtracts it), but the campaign Senders tab added up raw daily limits. With warmup at its 20/day cap, six 30/day mailboxes showed 180/day when only about 60 were really available for the campaign. - GET /api/campaigns/:id/sender-emails now also returns warmup_today (today's warmup ramp target) and campaign_capacity (daily_limit minus warmup_today). - Senders tab: new "For campaigns" column with the warmup share underneath; the capacity line uses campaign_capacity and says how much went to warmup. - Test covering a warming and a non-warming mailbox. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LQ9YMidHHSER256BUeZivC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The campaign Senders tab now shows what each mailbox can actually send for the campaign today, after warmup.
GET /api/campaigns/:id/sender-emailsalso returnswarmup_today(today's warmup ramp target, fromrampTarget) andcampaign_capacity(daily_limit - warmup_today, floored at 0). Existing fields are unchanged.campaign_capacityand, when warmup is on, reads e.g. "mailbox limits 180 minus 120 warmup, campaign limit 1,000".Why
planCampaignalready takes warmup sends out of the same daily limit ("so the two never stack"), but the tab added up rawdaily_limits. We hit this in our first campaign: six 30/day mailboxes at the 20/day warmup cap showed 180/day, when only about 60 were really available. It looked like a hard 30/day limit was in the way.How tested
server/test/engine.test.ts: one mailbox warming for a month (20/day cap) and one not, both at 50/day. The route reports 20 → 30 and 0 → 50.server/test/engine.test.tspasses (20/20).npm run typecheck -w serverand-w webare clean.npm test, so CI here is the real check.Not changed (possible follow-up)
The Add sender emails modal still shows "+N emails/day capacity" from raw limits, because
/api/sender-emailsdoesn't carry the ramp target. I left it out to keep this focused.🤖 Generated with Claude Code
https://claude.ai/code/session_01LQ9YMidHHSER256BUeZivC