Repository navigation
Conversation
tabwriter pads every cell to its column, so a row whose trailing cells are empty, a mutator's OK with no MESSAGE, or an errored describe row with nothing to say, ended in spaces. flushText now renders through a buffer and trims each line. cluster features describe drops its "No feature flags found." stderr line: the empty header already says so, as it does on every other table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text tables ended a row in padding whenever its last cells were empty: a mutator's
OKwith no MESSAGE, or an errored describe row with nothing after ERROR. tabwriter pads every cell to its column, soflushTextnow renders through a buffer and trims each line.cluster features describeon a broker with no features printed an empty header and a "No feature flags found." line on stderr; the stderr line is gone, since the empty header says the same thing every other table says it with.Text only; awk and JSON are unchanged.
Changelog
CHANGED
cluster features describeon a broker with no features prints the header only, without a stderr line.