8000 feat(runner): fixture-only node-pty runner adapter, first slice (#153) by simon-inkie · Pull Request #231 · simon-inkie/inkie-deck · GitHub
[go: up one dir, main page]

Skip to content

feat(runner): fixture-only node-pty runner adapter, first slice (#153) - #231

Merged
simon-inkie merged 11 commits into
mainfrom
153-node-pty-runner
Nov 19, 2026
Merged

simon-inkie merged 11 commits into
mainfrom
153-node-pty-runner

Conversation

@simon-inkie
@simon-inkie simon-inkie commented Nov 19, 2026 •
Copy link
Copy Markdown
Owner

First slice of the tmux to node-pty migration, as specified in .specs/153-tmux-to-node-pty/SPEC.md (this branch carries the spec, so draft PR 199 is superseded by it).

Adds a runner adapter interface (launch, input, output, resize, cancel, exit) with a node-pty implementation (optional dependency, loads lazily so Deck stays usable without it) and a tmux implementation behind the same contract, plus contract tests run against both: delayed output, failed launch, cancellation, process-group cleanup, input refused after exit, resize. Fixtures only: no production route or script changes, no live agent changes runner, tmux remains the default. Includes the inventory of every tmux assumption in the code. CI now installs tmux for the real-tmux cases.

Verified locally on the merged tree: typecheck, boundaries, leak gate, licence, lib-version, dashes, diff check and the full suite (126 files, 2559 tests). The full real-tmux cases ran outside the sandbox.


Devin Review

simon-inkie and others added 10 commits November 18, 2026 13:26
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
Runner interface, TmuxRunner wrapper and PtyRunner (node-pty, loaded lazily),
a fixture registry confined to the temporary directory, a scripted fixture
agent, a shared contract suite run against both runners, and an import-graph
test that no production module can reach PtyRunner. Production still uses tmux.
SPEC records the touch-point inventory and the drained-cutover rule.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
…nup tests (#153)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
…rors (#153)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
… regressions (#153)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
…lines (#153)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…153)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
devin-ai-integration[bot]

This comment was marked as resolved.

… list setup.sh (#153)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
@simon-inkie
simon-inkie merged commit 2d0766c into main Nov 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0