8000 feat(base): cross-harness wiring for Codex and Antigravity agents (#214) by simon-inkie · Pull Request #217 · simon-inkie/inkie-deck · GitHub
[go: up one dir, main page]

Skip to content

feat(base): cross-harness wiring for Codex and Antigravity agents (#214) - #217

Merged
simon-inkie merged 5 commits into
mainfrom
feat/multi-harness-wiring
Nov 19, 2026
Merged

simon-inkie merged 5 commits into
mainfrom
feat/multi-harness-wiring

Conversation

@simon-inkie
Copy link
Copy Markdown
Owner

Ports the generic cross-harness wiring so Claude Code, Codex and Antigravity agents are created, launched and wired the same way. Spec: .specs/214-multi-harness-wiring/SPEC.md (port and not-port list, truth table).

  • runtime-launch.sh shared by both launchers; Antigravity launch and resume
  • AGENTS.md, GEMINI.md and Codex hooks templates; Codex session-start and per-prompt hooks; Gemini include sync
  • create-agent.sh --runtime claude|codex|agy; first-run passes it through
  • Tests: 29 shell cases and 22 vitest cases; docs updated

Verified: typecheck, full test (base 187, deck 2415 passed 11 skipped), boundaries, leaks, licence, lib-version, dashes all clean on the committed tree. Codex hook behaviour and the agy prompt and resume flags checked against current docs. Not ported: bypass flags, auto-mode hooks, memory hooks, quota and cron wrappers. Live checks against real Codex and agy are off by default.

simon-inkie and others added 3 commits November 18, 2026 23:38
Shared runtime launch helpers, Antigravity launch and resume, AGENTS.md and
GEMINI.md persona templates, Codex session-start and per-prompt hooks, Gemini
include sync, and create-agent --runtime claude|codex|agy.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
…eview (#214)

Refuse to overwrite or follow symlinks for Codex hooks, verify hooks without
executing them, anchor Gemini sync markers and write atomically, probe the real
GEMINI.md, resolve Codex resume from the launch CODEX_HOME, and keep the boot
phrase when persona text is truncated.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
@simon-inkie
simon-inkie marked this pull request as ready for review November 19, 2026 02:13
devin-ai-integration[bot]

This comment was marked as resolved.

simon-inkie and others added 2 commits November 19, 2026 03:13
#214)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
@devin-ai-integration devin-ai-integration Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Devin Review

Comment on lines +1239 to +1241
for f in ${runtime_files[@]+"${runtime_files[@]}"}; do
[[ -f "$AGENT_HOME/$f" && ! -L "$AGENT_HOME/$f" && -r "$AGENT_HOME/$f" && -s "$AGENT_HOME/$f" ]] || return 1
done
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Runtime status does not validate hooks

A non-empty but malformed .codex/hooks.json passes --status, so first-run skips that Codex agent. The completeness check detects missing files, not broken hook wiring.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

@simon-inkie
Copy link
Copy Markdown
Owner Author

Thanks for the three resolutions. On the remaining analysis note: --status is deliberately a cheap, read-only presence check (it must not parse or run anything, so first-run can call it freely). Malformed hook content is caught by --verify-only, which statically validates the JSON and compares the commands against the scaffold without executing them. Deferred as intended; the SPEC truth table lists status as presence-only.

@simon-inkie
simon-inkie merged commit aff6f94 into main Nov 19, 2026
5 checks passed
@simon-inkie
simon-inkie deleted the feat/multi-harness-wiring branch November 19, 2026 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0