Repository navigation
feat(acp): Agent Client Protocol client and event envelope, first slice (#154) - #209
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
…nly first slice (#154) Pins ACP protocol 1 with @agentclientprotocol/sdk 1.9.0 (test-harness dependency), a session client with capability negotiation, ordered events, explicit permission choices, cancellation and disconnect cleanup, strict turn settlement, and the shared bounded event envelope. Proven against a scripted fixture agent. No production route, UI or real-agent adapter. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
simon-inkie
marked this pull request as ready for review
November 18, 2026 18:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First slice of #154, fixture-only: no production route, UI or real-agent adapter. Builds on the spec in #200 (this branch includes its commit).
@agentclientprotocol/sdk1.9.0 (test-harness dependency; the v2 draft is not used).end_turnis success), rejection of wrong, duplicate, malformed or oversized messages.Checks: typecheck, boundaries, leak gate, diff check clean; full Deck suite 2363 passed. One unrelated flake seen once in the base suite (
create-agentdetached-child test), not touched here.Closes nothing: #154 stays open for the real adapters.