8000 feat(acp): Agent Client Protocol client and event envelope, first slice (#154) by simon-inkie · Pull Request #209 · simon-inkie/inkie-deck · GitHub
[go: up one dir, main page]

Skip to content

feat(acp): Agent Client Protocol client and event envelope, first slice (#154) - #209

Merged
simon-inkie merged 2 commits into
mainfrom
154-acp-client
Nov 18, 2026
Merged

simon-inkie merged 2 commits into
mainfrom
154-acp-client

Conversation

@simon-inkie
Copy link
Copy Markdown
Owner

First slice of #154, fixture-only: no production route, UI or real-agent adapter. Builds on the spec in #200 (this branch includes its commit).

  • Pins ACP protocol 1 with @agentclientprotocol/sdk 1.9.0 (test-harness dependency; the v2 draft is not used).
  • Session client: capability negotiation and refusal, queued prompts, ordered events, explicit permission choices, cancellation, disconnect and process-group cleanup, strict turn settlement (only a valid end_turn is success), rejection of wrong, duplicate, malformed or oversized messages.
  • Shared event envelope (decision, action, happened) with a bounded typed display projection, for Replace tmux with a cross-platform node-pty runner #153 and Epic: structured task flows, source tickets and durable runs #155 to use.
  • Proven against a scripted fixture agent: 22 tests.
  • SPEC Log records the decisions the spec left open and the direction that Claude runs through the node-pty runner (Replace tmux with a cross-platform node-pty runner #153) while Codex, Antigravity and other ACP agents use this path in later slices.

Checks: typecheck, boundaries, leak gate, diff check clean; full Deck suite 2363 passed. One unrelated flake seen once in the base suite (create-agent detached-child test), not touched here.

Closes nothing: #154 stays open for the real adapters.

simon-inkie and others added 2 commits November 18, 2026 13:26
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
…nly first slice (#154)

Pins ACP protocol 1 with @agentclientprotocol/sdk 1.9.0 (test-harness
dependency), a session client with capability negotiation, ordered events,
explicit permission choices, cancellation and disconnect cleanup, strict turn
settlement, and the shared bounded event envelope. Proven against a scripted
fixture agent. No production route, UI or real-agent adapter.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
@simon-inkie
simon-inkie marked this pull request as ready for review November 18, 2026 18:05
@devin-ai-integration devin-ai-integration Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@simon-inkie
simon-inkie merged commit abadbfc into main Nov 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0