8000 ci: type check with tsgo by simon-inkie · Pull Request #204 · simon-inkie/inkie-deck · GitHub
[go: up one dir, main page]

Skip to content

ci: type che 8000 ck with tsgo - #204

Merged
simon-inkie merged 2 commits into
mainfrom
ci/tsgo-typecheck
Nov 18, 2026
Merged

simon-inkie merged 2 commits into
mainfrom
ci/tsgo-typecheck

Conversation

@simon-inkie
@simon-inkie simon-inkie commented Nov 18, 2026 •
Copy link
Copy Markdown
Owner

Switches the CI type check to tsgo (TypeScript native). pnpm typecheck now runs react-router typegen then tsgo --noEmit; the old path is kept as pnpm typecheck:tsc. The unit tests already ran in the test (22.x) and test (24.x) jobs, and the job names are unchanged so branch protection still matches.

Local: tsgo and tsc both exit 0 on this tree. Risk: native preview diagnostics can differ from tsc, and it ships a platform binary; the tsc script is the fallback. Docs that listed the command are updated.


Devin Review

pnpm typecheck now runs react-router typegen then tsgo --noEmit. The tsc path
stays as pnpm typecheck:tsc. Job names are unchanged, so branch protection
still matches. Unit tests were already part of the test jobs.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
@devin-ai-integration devin-ai-integration Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Devin Review: 1 flag

Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

Devin Review

Comment on lines +31 to +36
### 2026-11-18: Verify the fallback and offline blocker
- What changed: verified that the original `pnpm typecheck` and the new
`pnpm typecheck:tsc` both pass with TypeScript 5.9.3. Native diagnostics
remain unverified: pnpm could not resolve the preview offline.
- Why: confirm the fallback works and leave the lockfile update to a run
with registry access.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Stale native typecheck verification record

The SPEC records tsgo as unverified, but the PR description reports both compilers passing. The committed lockfile also contains the dependency previously described as blocked. The required handover record leaves the final verification state unclear.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 7ff21ee: the SPEC now has a later entry recording that the lockfile was regenerated and tsgo verified. The earlier entry is kept as history (the SPEC is append-only).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
@simon-inkie
simon-inkie merged commit 8244478 into main Nov 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0