Repository navigation
ci: type che 8000 ck with tsgo - #204
Conversation
pnpm typecheck now runs react-router typegen then tsgo --noEmit. The tsc path stays as pnpm typecheck:tsc. Job names are unchanged, so branch protection still matches. Unit tests were already part of the test jobs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
| ### 2026-11-18: Verify the fallback and offline blocker | ||
| - What changed: verified that the original `pnpm typecheck` and the new | ||
| `pnpm typecheck:tsc` both pass with TypeScript 5.9.3. Native diagnostics | ||
| remain unverified: pnpm could not resolve the preview offline. | ||
| - Why: confirm the fallback works and leave the lockfile update to a run | ||
| with registry access. |
There was a problem hiding this comment.
🔍 Stale native typecheck verification record
The SPEC records tsgo as unverified, but the PR description reports both compilers passing. The committed lockfile also contains the dependency previously described as blocked. The required handover record leaves the final verification state unclear.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Addressed in 7ff21ee: the SPEC now has a later entry recording that the lockfile was regenerated and tsgo verified. The earlier entry is kept as history (the SPEC is append-only).
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
Switches the CI type check to tsgo (TypeScript native).
pnpm typechecknow runsreact-router typegenthentsgo --noEmit; the old path is kept aspnpm typecheck:tsc. The unit tests already ran in thetest (22.x)andtest (24.x)jobs, and the job names are unchanged so branch protection still matches.Local: tsgo and tsc both exit 0 on this tree. Risk: native preview diagnostics can differ from tsc, and it ships a platform binary; the tsc script is the fallback. Docs that listed the command are updated.