8000 feat(deck): first-run hints for an agent waiting in its terminal (#201) by simon-inkie · Pull Request #203 · simon-inkie/inkie-deck · GitHub
[go: up one dir, main page]

Skip to content

feat(deck): first-run hints for an agent waiting in its terminal (#201) - #203

Merged
simon-inkie merged 2 commits into
mainfrom
201-first-run-hints
Nov 18, 2026
Merged

simon-inkie merged 2 commits into
mainfrom
201-first-run-hints

Conversation

@simon-inkie
@simon-inkie simon-inkie commented Nov 18, 2026 •
Copy link
Copy Markdown
Owner

Closes #201.

Deck now explains when an agent is waiting in its terminal and what to do if a new thread stays empty, without sending keys. A conservative matcher reads the captured pane text for Claude's first-run dialogs (folder trust, sign-in, key approval, other setup screens) and a shell prompt after the agent exits. The thread page shows a banner with an Open terminal link, and the terminal view gets one line above the key buttons. Hints clear on the next successful refresh. The chat response carries a hint id only, never pane text. Nothing sends a key or stores state.

Spec: .specs/201-first-run-hints/SPEC.md (first slice only). Left out as agreed: a Hide button, the Provider badge change, the sidebar dot.

Checks: leak gate, boundaries, dash and ASCII scans, diff check; 57 targeted tests pass (matcher, loader, banner, terminal view, with negative cases for ordinary output that resembles a dialog). Reviewed by two independent reviewers; the matcher false-positive, shell-prompt anchoring and live-region findings are fixed in the second commit.

Not done before merge: the dialog patterns are covered by sanitised simulated fixtures only and still need confirming against real CLI captures on a signed-in machine; the new e2e case has not been run; the full Deck suite has failures that also appear on main in the review sandbox.


Devin Review

simon-inkie and others added 2 commits November 18, 2026 15:29
Adds a conservative matcher over the captured pane text, a hint banner on
the thread page and a line in the terminal view. Hints clear on the next
successful refresh, the chat response carries a hint id only (never pane
text), and nothing sends a key. Menu patterns are covered by sanitised
simulated fixtures; confirmation against real CLI captures is still pending.

Refs #201.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
Requires a hint's wording and its menu controls to sit in the same current
block, rejects busy or idle output below it, anchors the shell-exit hint to
the start of the last line, keeps the live regions mounted and preserves
focus, and adds negative tests for each case.

Refs #201.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
@devin-ai-integration devin-ai-integration Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Devin Review: 1 flag

Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

Devin Review

@@ -0,0 +1,51 @@
import { HINT_SHELL_PROMPT_RE } from "./pane-prompts";

/** Pattern provenance: base boot fixtures and synthetic examples; CLI versions unverified. */
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Live dialog compatibility remains unverified

classifyPaneHint rejects menus with extra explanatory rows or footers beyond Enter to confirm. Simulated fixtures cannot establish whether live dialogs satisfy those constraints. Real captures remain necessary to verify that first-run hints appear.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

@simon-inkie
simon-inkie merged commit 2ec167c into main Nov 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

first-run hints in Deck

1 participant

0