Repository navigation
feat(deck): first-run hints for an agent waiting in its terminal (#201) - #203
Merged
Merged
Conversation
Adds a conservative matcher over the captured pane text, a hint banner on the thread page and a line in the terminal view. Hints clear on the next successful refresh, the chat response carries a hint id only (never pane text), and nothing sends a key. Menu patterns are covered by sanitised simulated fixtures; confirmation against real CLI captures is still pending. Refs #201. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
Requires a hint's wording and its menu controls to sit in the same current block, rejects busy or idle output below it, anchors the shell-exit hint to the start of the last line, keeps the live regions mounted and preserves focus, and adds negative tests for each case. Refs #201. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Simon Dixon <simon-inkie@users.noreply.github.com>
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
| @@ -0,0 +1,51 @@ | |||
| import { HINT_SHELL_PROMPT_RE } from "./pane-prompts"; | |||
|
|
|||
| /** Pattern provenance: base boot fixtures and synthetic examples; CLI versions unverified. */ | |||
There was a problem hiding this comment.
🔍 Live dialog compatibility remains unverified
classifyPaneHint rejects menus with extra explanatory rows or footers beyond Enter to confirm. Simulated fixtures cannot establish whether live dialogs satisfy those constraints. Real captures remain necessary to verify that first-run hints appear.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #201.
Deck now explains when an agent is waiting in its terminal and what to do if a new thread stays empty, without sending keys. A conservative matcher reads the captured pane text for Claude's first-run dialogs (folder trust, sign-in, key approval, other setup screens) and a shell prompt after the agent exits. The thread page shows a banner with an Open terminal link, and the terminal view gets one line above the key buttons. Hints clear on the next successful refresh. The chat response carries a hint id only, never pane text. Nothing sends a key or stores state.
Spec:
.specs/201-first-run-hints/SPEC.md(first slice only). Left out as agreed: a Hide button, the Provider badge change, the sidebar dot.Checks: leak gate, boundaries, dash and ASCII scans, diff check; 57 targeted tests pass (matcher, loader, banner, terminal view, with negative cases for ordinary output that resembles a dialog). Reviewed by two independent reviewers; the matcher false-positive, shell-prompt anchoring and live-region findings are fixed in the second commit.
Not done before merge: the dialog patterns are covered by sanitised simulated fixtures only and still need confirming against real CLI captures on a signed-in machine; the new e2e case has not been run; the full Deck suite has failures that also appear on main in the review sandbox.