8000 No Windows (WSL) install path in INSTALL.md (#26) by simon-inkie · Pull Request #59 · simon-inkie/inkie-deck · GitHub
[go: up one dir, main page]

Skip to content

No Windows (WSL) install path in INSTALL.md (#26) - #59

Merged
simon-inkie merged 4 commits into
mainfrom
26-windows-wsl-install
Oct 12, 2026
Merged

simon-inkie merged 4 commits into
mainfrom
26-windows-wsl-install

Conversation

@simon-inkie
@simon-inkie simon-inkie commented Oct 11, 2026 •
Copy link
Copy Markdown
Owner

Requested by Simon · project thread

What was wrong

INSTALL.md listed Windows as unverified and gave no guidance, so a Windows user hit the WSL traps from the 2026-09-27 test unaided.

What changed

  • New "Windows (via WSL)" section before section 1, written for a non-developer: install WSL2 and Ubuntu, root-user recovery, default distro, repo in the Linux home (not /mnt/c), links to the Linux install steps, line endings, the model CLI (Linux install, PATH interop, sign-in, trust-home warning), opening Deck from a Windows browser, keeping it running (tmux, or a systemd user service with enable and enable-linger).
  • powershell added to the rig's known fence languages, so Windows-side blocks are accounted for but not run.
  • Review fixes: sudo instructions (sudo -i, paste, exit, re-run the export) in the Windows section and section 1; the limitation line says plainly nobody has followed the Windows section end to end; sections 4 and 5 link back; localhost fallback; tmux survival flagged inline as unchecked; /etc/wsl.conf edited with an editor; renamed heading so the #keep-it-running anchor still points at section 4; enable and enable-linger added so Deck comes back after a restart.
  • SPEC at .specs/26-windows-wsl-install/SPEC.md, with the review feedback recorded.

How verified

On Linux:

  • node rig/self-test.mjs passes (79 checks).
  • typecheck, check:boundaries, check:leaks, check:licence, check:lib-version, check:dashes pass.
  • The CRLF shebang failure message in the doc is the real output of a CRLF script here.
  • git ls-files --eol shows attr/text=auto eol=lf for tracked files, and a CRLF working file is normalised on add.
  • ps -p 1 -o comm= works as the systemd check.

What could not be verified

Nothing Windows-specific was run. From documentation only, and not verified on a real Windows machine:

  • wsl --install -d Ubuntu-24.04, wsl --list --verbose, wsl --set-default, wsl --cd ~, wsl --shutdown.
  • The root-user recovery (adduser, usermod, [user] default= in /etc/wsl.conf).
  • [interop] appendWindowsPath = false and its side effects.
  • [boot] systemd=true, and that recent Ubuntu images often have it on.
  • localhost forwarding from the Windows browser to Deck bound on loopback, and the 127.0.0.1 fallback.
  • \\wsl.localhost\Ubuntu-24.04\... in File Explorer.
  • Whether tmux survives Windows stopping Ubuntu with no window open.
  • Whether systemctl --user enable deck plus loginctl enable-linger brings Deck back after a Windows restart and an Ubuntu start, with no window open.
  • The CLI sign-in flow and folder-trust prompt wording.
  • sudo -i then exit then re-exporting works as described (standard Ubuntu behaviour, not run here).

Not run: the Docker install rig (no Docker here). pnpm test has two failures in packages/base, identical on main (no xxd here). check:leaks:messages and check:leaks:history are red on older commits on main, not this branch.

Refs #26 (acceptance needs a real clean Windows 11 run, so this should not close the issue)

🤖 Generated with Claude Code

https://claude.ai/code/session_01ByrScobyMJ5eQ8EQZzEcWB

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@simon-inkie simon-inkie self-assigned this Oct 11, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
#26)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@simon-inkie
Copy link
Copy Markdown
Owner Author

Review: merge after fixes

  • Major INSTALL.md (WSL section, around line 306): the text says Deck is back after a Windows restart as soon as Ubuntu starts, but the steps it points to in "Keep it running" only run systemctl --user start deck. Starting is not enabling, so after a restart nothing brings it back. The WSL path should tell the reader to systemctl --user enable deck (the main section mentions enable only in passing) and say whether lingering is needed under WSL.
  • Minor: none of the WSL-specific steps were executed end to end. Please keep the list of unverified steps in the PR description so a maintainer knows what to test on a real Windows machine.

No scope creep, no private material, no tests weakened.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@simon-inkie
simon-inkie force-pushed the 26-windows-wsl-install branch from 06c017a to 1c6b7d4 Compare October 11, 2026 16:22
@simon-inkie
Copy link
Copy Markdown
Owner Author

Fixed in 1c6b7d4: the Windows section now adds systemctl --user enable deck and loginctl enable-linger "$USER" after the systemd steps. It says what each does, that lingering is what keeps Deck up with no Ubuntu window open, and that Deck still does not start with Windows itself.

The PR description already lists every unverified step. Whether lingering behaves as described under WSL is added to that list.


Generated by Claude Code

@simon-inkie
Copy link
Copy Markdown
Owner Author

Re-review of 1c6b7d4: fixed, good to merge. The WSL section now adds systemctl --user enable deck and loginctl enable-linger, explains each, and is clear that nothing starts with Windows itself. Unverified-steps list is kept. Checks green.

@simon-inkie
simon-inkie merged commit e51a322 into main Oct 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0