8000 Google Fonts never load (import dropped after Tailwind) (#32) by simon-inkie · Pull Request #51 · simon-inkie/inkie-deck · GitHub
[go: up one dir, main page]

Skip to content

Google Fonts never load (import dropped after Tailwind) (#32) - #51

Merged
simon-inkie merged 3 commits into
mainfrom
32-google-fonts-never-load
Oct 7, 2026
Merged

simon-inkie merged 3 commits into
mainfrom
32-google-fonts-never-load

Conversation

@simon-inkie
Copy link
Copy Markdown
Owner

Closes #32

Summary

  • The font @import in app.css sat after the Tailwind import, so it was no longer first once Tailwind inlined, and browsers dropped it. The app rendered in fallback fonts even when online.
  • The font stylesheet is now a <link> in links in app/root.tsx, beside the existing preconnects. The dead @import is removed.
  • The INSTALL.md limitation no longer blames the network for the fonts failing when online.
  • SPEC: .specs/32-google-fonts-never-load/SPEC.md.

Verification

  • pnpm build: the @import rules must precede warning appeared twice before and is gone now. Built CSS has no googleapis reference.
  • pnpm dev: server-rendered HTML contains the font stylesheet link, and the dev log has no warning.
  • typecheck, boundaries, leaks, licence, lib-version and dashes pass. Deck tests: 2168 passed, 11 skipped.
  • Not measured: document.fonts in a clean browser profile, which needs a browser with access to Google Fonts.
  • Already failing on main: 4 packages/base tests (no xxd, no UTF-8 locale, no model CLI in this sandbox). Identical before and after this change.

Follow-up noted in the SPEC, not done here: self-host the fonts to remove the runtime egress dependency.

🤖 Generated with Claude Code

https://claude.ai/code/session_01HiCDb9ycQDW9cmu5ngmi2C


Generated by Claude Code

claude added 3 commits October 7, 2026 14:12
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HiCDb9ycQDW9cmu5ngmi2C
Signed-off-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HiCDb9ycQDW9cmu5ngmi2C
Signed-off-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HiCDb9ycQDW9cmu5ngmi2C
Signed-off-by: Claude <noreply@anthropic.com>
@simon-inkie
Copy link
Copy Markdown
Owner Author

Review leg: Aggy (AI review agent). Verdict: ready to merge.
Checked: matches issue #32; Google Fonts stylesheet loaded via canonical Remix links export in root.tsx; dropped PostCSS @import removed; build warning eliminated; limitation text updated; SPEC present and consistent; public-repo hygiene clean (UK English, no em-dashes).
Not verified: external font network egress in a clean browser profile.
Merge decision stays with the maintainer.

@simon-inkie
simon-inkie merged commit d44dad4 into main Oct 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Google Fonts never load (import dropped after Tailwind)

2 participants

0