8000 INSTALL.md never tells you to clone the repo (#22) by simon-inkie · Pull Request #49 · simon-inkie/inkie-deck · GitHub
[go: up one dir, main page]

Skip to content

INSTALL.md never tells you to clone the repo (#22) - #49

Merged
simon-inkie merged 3 commits into
mainfrom
22-install-clone-step
Oct 7, 2026
Merged

simon-inkie merged 3 commits into
mainfrom
22-install-clone-step

Conversation

@simon-inkie
Copy link
Copy Markdown
Owner

Closes #22

Summary

  • INSTALL.md gains an explicit git clone ... && cd inkie-deck step at the end of section 1, plus a temporary note that a private repo needs gh auth login inside the Linux environment.
  • Leak gate: a narrow content-scope exemption for the canonical clone URL on the first-name rule only. The self-test proves the name still fires on the bare name, a different repo, a longer repo name, a different host, and beside an exempt URL on the same line.
  • Install rig: the clone block is declared as skipped in rig/install-plan.mjs with a reason (no credentials in the container, repo is private, the rig copies the tree in). Skips count as claimed in coverage, and a stale skip fails the rig. Rig self-test covers both.
  • SPEC at .specs/22-install-clone-step/SPEC.md.

Checks

Pass: check:leaks and --self-test, check:boundaries, check:licence, check:lib-version, check:dashes, typecheck, rig/self-test.mjs.

Already failing on main, not from this change: 4 pnpm test failures (missing xxd, no LANG here, as INSTALL.md section 1 describes) and 6 check:leaks:messages findings in older commits. The Docker rig was not run (no Docker here).

Follow-ups are listed in the SPEC.

🤖 Generated with Claude Code


Generated by Claude Code

claude added 3 commits October 7, 2026 14:10
Signed-off-by: Claude <noreply@anthropic.com>
…he leak gate (#22)

Signed-off-by: Claude <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@simon-inkie
Copy link
Copy Markdown
Owner Author

Review leg: Aggy (AI review agent). Verdict: ready to merge.
Checked: matches issue #22; clone step added to INSTALL.md; rig and leak-gate changes are issue-mandated by acceptance criteria; leak-gate self-test passes; SPEC present and consistent; public-repo hygiene clean (UK English, no em-dashes).
Not verified: automated container install rig run (requires Docker daemon).
Merge decision stays with the maintainer.

@simon-inkie
simon-inkie merged commit 1cdfc5a into main Oct 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

INSTALL.md never tells you to clone the repo

2 participants

0