Repository navigation
feat(deck): run the deck as a user service so it survives terminal close (#29) - #48
simon-inkie wants to merge 4 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018uNaFhmK6yxSR7XfzJDY3Z Signed-off-by: Simon <simon@inkie.ink>
Review, Sonnet, 2026-10-02PR 48 (deck issue 29, systemd user service). SHA reviewed: 719476d Verdict: NEEDS CHANGES (1 Major, moderate confidence; see below) Ran CriticalNone. Major
Minor
Nit
Not checked
|
…ew fixes) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Simon <simon@inkie.ink>
EnvironmentFile= is glob-matched, so a literal backslash in the checkout path must be escaped; WorkingDirectory= keeps it as is. The launcher test now feeds the rendered value to systemd-run and probes with a CommonJS script, since Node's ES module loader rejects backslashes in filenames. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Simon <simon@inkie.ink>
EnvironmentFile= is glob-matched, so escape \ * ? [ (backslash first) in the rendered path; WorkingDirectory= stays literal. Fixtures now use a directory name with those characters plus a decoy sibling env file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Simon <simon@inkie.ink>
|
Fixes pushed: 980b3b7, bca8940, 9a5d76c (head 9a5d76c). EnvironmentFile now escapes backslash, star, question mark and open bracket; WorkingDirectory stays literal. Review legs: Sonnet on bca8940 (PASS with notes, the glob-set note is fixed in 9a5d76c); Aggy on 9a5d76c (PASS, 9/9 service tests including the live systemd-run transient unit). Sol finished the escaping and ran the leak gate (clean). Reviews follow. |
Review: deck EnvironmentFile backslash doubling (bca8940, parent 980b3b7)Verdict: PASS with notes. Scope: Answers to the four questions
FindingsMajor: none. Minor
Nit
Not checked
|
Deck PR 48 Fix Round C Review (Aggy - Independent Review Leg)
1. Scope & ObjectiveAudit the round C fix for Deck PR 48 (
2. Findings (Ranked)[Observation / Good Practice] Comprehensive Glob Metacharacter Escaping
[Observation / Good Practice] Decoy Fixture Defends Against Accidental Glob Expansion
3. Test Suite VerificationThe full test suite was executed against the active systemd user bus: pnpm -C packages/deck test test/deck-service.test.tsResults:
All 9 tests passed. 4. Public Repository HygieneVerified:
|
Closes #29.
Reviewed at 719476d, two independent legs (CodeRabbit is off):
Both reviews checked that the tests fail without the change.
🤖 Generated with Claude Code
https://claude.ai/code/session_018uNaFhmK6yxSR7XfzJDY3Z