8000 Harden external TestFlight upload claims by shroominic · Pull Request #31 · shroominic/OpenGlucose · GitHub
[go: up one dir, main page]

Skip to content

Harden external TestFlight upload claims - #31

Merged
shroominic merged 1 commit into
mainfrom
fix/testflight-upload-attempt
Aug 14, 2026
Merged

shroominic merged 1 commit into
mainfrom
fix/testflight-upload-attempt

Conversation

@shroominic
Copy link
Copy Markdown
Owner

What changed

  • atomically claims an external TestFlight upload only after every deterministic build, signing, review-metadata, and audience preflight
  • queries App Store Connect for the exact iOS version/build across all processing states before claiming
  • derives one immutable claim path from finalized provenance and makes pilot upload the immediately following command
  • binds final provenance to the immutable attempt, exact source/IPA digest, and exact APP_STORE_ELIGIBLE build
  • blocks normal reruns, pending-only recovery/notification, inconsistent final-only state, and managed path collisions
  • documents the unavoidable App Store Connect digest/delivery-identity limitation and exclusive-upload-authority requirement

Why

An upload can succeed remotely while the client is interrupted before it records local provenance. A mutable version/build lookup cannot prove which IPA produced that remote build, and concurrent runners must not both cross the non-idempotent upload boundary.

Impact

A successful run permanently retains both mode-400 records. A pending attempt is an incident: automation will not delete, recover, associate, or notify it, and the release owner must preserve it and cut a new build number.

Validation

  • full repository pre-push make check gate passed
  • make tooling-check
  • targeted Flutter release-policy test
  • Ruby and shell syntax checks
  • deterministic state/order/schema/tamper/wrong-token/concurrency tests
  • independent final review found no P0/P1 issue

@shroominic
shroominic merged commit 4561999 into main Aug 14, 2026
9 checks passed
@shroominic
shroominic deleted the fix/testflight-upload-attempt branch August 14, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0